Merge pull request #6554 from seadowg/form-size-logging

Log form and CSV instance sizes when loading
getodk · Dec 19, 2024 · c427388 · c427388
2 parents 1fdc79f + 0b52f51
commit c427388
Showing 1 changed file with 32 additions and 1 deletion.
diff --git a/collect_app/src/main/java/org/odk/collect/android/tasks/FormLoaderTask.java b/collect_app/src/main/java/org/odk/collect/android/tasks/FormLoaderTask.java
@@ -67,6 +67,7 @@
 import java.io.FileFilter;
 import java.io.FileReader;
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
 
@@ -192,6 +193,8 @@ protected FECWrapper doInBackground(Void... ignored) {
         unzipMediaFiles(formMediaDir);
         setupReferenceManagerForForm(ReferenceManager.instance(), formMediaDir);
 
+        logFormDetails(formXml, formMediaDir);
+
         FormDef formDef = null;
         try {
             formDef = createFormDefFromCacheOrXml(form.getFormFilePath(), formXml);
@@ -276,6 +279,35 @@ protected FECWrapper doInBackground(Void... ignored) {
         return data;
     }
 
+    private void logFormDetails(File formFile, File formMediaDir) {
+        long formFileBytesSize = formFile.length();
+
+        List<String> csvFileBytesSizes = new ArrayList<>();
+        File[] files = formMediaDir.listFiles();
+        if (files != null) {
+            for (File mediaFile : files) {
+                if (mediaFile.getName().endsWith(".csv")) {
+                    csvFileBytesSizes.add(mediaFile.length() + "B");
+                }
+            }
+        }
+
+        if (csvFileBytesSizes.isEmpty()) {
+            Timber.w(
+                    "Attempting to load from %s, file is %dB",
+                    formFile.getAbsolutePath(),
+                    formFileBytesSize
+            );
+        } else {
+            Timber.w(
+                    "Attempting to load from %s, file is %dB and has CSV files %s",
+                    formFile.getAbsolutePath(),
+                    formFileBytesSize,
+                    String.join(", ", csvFileBytesSizes)
+            );
+        }
+    }
+
     private static void unzipMediaFiles(File formMediaDir) {
         File[] zipFiles = formMediaDir.listFiles(new FileFilter() {
             @Override
@@ -305,7 +337,6 @@ private FormDef createFormDefFromCacheOrXml(String formPath, File formXml) throw
         }
 
         // no binary, read from xml
-        Timber.i("Attempting to load from: %s", formXml.getAbsolutePath());
         final long start = System.currentTimeMillis();
         String lastSavedSrc = FileUtils.getOrCreateLastSavedSrc(formXml);
         FormDef formDefFromXml = XFormUtils.getFormFromFormXml(formPath, lastSavedSrc);