fix utf8 serialization

- lengths were not guaranteed to be the same between tchar and utf8. This might've been a long-standing bug!
getnamo · Dec 3, 2023 · 66f5e40 · 66f5e40
1 parent 6e5786a
commit 66f5e40
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/Source/CoreUtility/Private/CUBlueprintLibrary.cpp b/Source/CoreUtility/Private/CUBlueprintLibrary.cpp
@@ -47,7 +47,12 @@ FString UCUBlueprintLibrary::Conv_BytesToString(const TArray<uint8>& InArray)
 TArray<uint8> UCUBlueprintLibrary::Conv_StringToBytes(FString InString)
 {
 	TArray<uint8> ResultBytes;
-	ResultBytes.Append((uint8*)TCHAR_TO_UTF8(*InString), InString.Len());
+
+	FTCHARToUTF8 UTF8String(*InString);
+
+	int32 UTF8Len = UTF8String.Length();
+
+	ResultBytes.Append((uint8*)UTF8String.Get(), UTF8Len);
 	return ResultBytes;
 }