Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use internal server to test requests passthrough #8419

Merged

Conversation

bblommers
Copy link
Collaborator

Fixes #8400

@bblommers bblommers added this to the 5.0.24 milestone Dec 18, 2024
@bblommers bblommers force-pushed the core-fix-requests-passthrough-test branch from f520cfe to c79d67a Compare December 18, 2024 21:58
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (3c4c72e) to head (c79d67a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8419   +/-   ##
=======================================
  Coverage   94.59%   94.60%           
=======================================
  Files        1163     1163           
  Lines      101636   101638    +2     
=======================================
+ Hits        96147    96152    +5     
+ Misses       5489     5486    -3     
Flag Coverage Δ
servertests 28.84% <ø> (+<0.01%) ⬆️
unittests 94.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit db93058 into getmoto:master Dec 18, 2024
53 checks passed
@bblommers bblommers deleted the core-fix-requests-passthrough-test branch December 18, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite fails as http://ip.jsontest.com is broken
1 participant