Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: complete_multipart_upload() should be able to overwrite #8418

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #8417

Followup to #8380 where this bug was introduced

@bblommers bblommers added this to the 5.0.24 milestone Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (3c4c72e) to head (2fd6b31).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8418   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files        1163     1163           
  Lines      101636   101636           
=======================================
  Hits        96147    96147           
  Misses       5489     5489           
Flag Coverage Δ
servertests 28.83% <0.00%> (ø)
unittests 94.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 6bf0cfc into getmoto:master Dec 18, 2024
53 checks passed
@bblommers bblommers deleted the s3-multipart-overwrite branch December 18, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multipart upload does not overwrite existing multipart-uploaded objects in Moto 5.0.23
1 participant