Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CognitoIDP: Ensure MFA functions work with non-python SDK's #8241

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #8238

@bblommers bblommers added this to the 5.0.18 milestone Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (1ace1db) to head (259ec76).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
moto/cognitoidp/models.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8241   +/-   ##
=======================================
  Coverage   94.54%   94.55%           
=======================================
  Files        1158     1158           
  Lines      100089   100147   +58     
=======================================
+ Hits        94629    94692   +63     
+ Misses       5460     5455    -5     
Flag Coverage Δ
servertests 28.89% <55.55%> (+0.01%) ⬆️
unittests 94.52% <92.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit fe37392 into getmoto:master Oct 19, 2024
53 checks passed
@bblommers bblommers deleted the cognitoidp-mfa-using-java-sdk branch October 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cognito-IDP: Access token and/or session not usable (Java Cognito IDP SDK v2)
1 participant