Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS: DBInstances: Ensure compatibility with NodeJS SDK #8222

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #8221

@bblommers bblommers added this to the 5.0.17 milestone Oct 10, 2024
@bblommers bblommers force-pushed the rds-in-js-sdk branch 3 times, most recently from f68d01b to 681057e Compare October 10, 2024 21:44
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (43410b9) to head (6a110ee).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8222    +/-   ##
========================================
  Coverage   94.53%   94.53%            
========================================
  Files        1155     1157     +2     
  Lines       99707    99973   +266     
========================================
+ Hits        94261    94513   +252     
- Misses       5446     5460    +14     
Flag Coverage Δ
servertests 28.80% <ø> (-0.05%) ⬇️
unittests 94.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers force-pushed the rds-in-js-sdk branch 2 times, most recently from 719f247 to f316c1e Compare October 11, 2024 17:46
@bblommers bblommers merged commit a6dc298 into getmoto:master Oct 11, 2024
54 checks passed
@bblommers bblommers deleted the rds-in-js-sdk branch October 11, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodejs @aws-sdk returns error Unable to parse boolean value "True"
1 participant