Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces Web Tagging Support #8217

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jamarcelin
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (43410b9) to head (1b61fa3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8217    +/-   ##
========================================
  Coverage   94.53%   94.54%            
========================================
  Files        1155     1157     +2     
  Lines       99707    99963   +256     
========================================
+ Hits        94261    94507   +246     
- Misses       5446     5456    +10     
Flag Coverage Δ
servertests 28.80% <13.51%> (-0.05%) ⬇️
unittests 94.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamarcelin
Copy link
Contributor Author

Hey @bblommers, any idea why this one check is failing?

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a flaky test @jamarcelin - don't worry about it.

Thank you for the PR!

@bblommers bblommers added this to the 5.0.17 milestone Oct 10, 2024
@bblommers bblommers merged commit 5b7010f into getmoto:master Oct 10, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants