Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces Web Tagging Support #8214

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jamarcelin
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (43410b9) to head (7bfadb4).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8214   +/-   ##
=======================================
  Coverage   94.53%   94.54%           
=======================================
  Files        1155     1155           
  Lines       99707    99787   +80     
=======================================
+ Hits        94261    94341   +80     
  Misses       5446     5446           
Flag Coverage Δ
servertests 28.84% <0.00%> (-0.01%) ⬇️
unittests 94.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @jamarcelin!

@bblommers bblommers added this to the 5.0.17 milestone Oct 8, 2024
@bblommers bblommers merged commit 21873d1 into getmoto:master Oct 8, 2024
53 checks passed
@jamarcelin jamarcelin deleted the workspaces-web-tagging-fixes branch October 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants