-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panorama: Add more feature about application instances #7624
base: master
Are you sure you want to change the base?
Panorama: Add more feature about application instances #7624
Conversation
8c91f4d
to
690aa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @YHallouard, would you mind fixing the merge conflicts?
690aa9e
to
5f3e433
Compare
5f3e433
to
e4f0cc3
Compare
Hi @bblommers, tests are running well on my computer, I don't really understand why it is failing on CI |
@mock_aws | ||
def test_describe_application_instance() -> None: | ||
# Given | ||
panorama_client = boto3.client("panorama") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panorama_client = boto3.client("panorama") | |
panorama_client = boto3.client("panorama", "eu-west-1") |
We assume that the ARN starts with arn:aws:panorama:eu-west-1..
- but that is only the case if the region is set to eu-west-1
. If the region is not explicitly configured, our CI assumes it is set in us-east-1
, which results in a different ARN.
This will need to be changed in the other tests as well.
No description provided.