Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: Streamline output of run_instances()/describe_instances() #6906

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

bblommers
Copy link
Collaborator

The duplicate copy/pasta nature before meant that run_instances() and describe_instances() were missing different fields in the response.

The output of both methods is now the same.

Fixes #6903

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #6906 (87f403a) into master (de714eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6906   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files         826      826           
  Lines       81059    81060    +1     
=======================================
+ Hits        77673    77674    +1     
  Misses       3386     3386           
Flag Coverage Δ
servertests 36.74% <100.00%> (+<0.01%) ⬆️
unittests 95.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
moto/ec2/responses/instances.py 99.13% <100.00%> (+<0.01%) ⬆️

@bblommers bblommers merged commit f59e178 into getmoto:master Oct 13, 2023
@bblommers bblommers deleted the ec2-streamline-instance-output branch October 13, 2023 08:05
@github-actions
Copy link
Contributor

This is now part of moto >= 4.2.6.dev33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EC2: Add support for hibernation APIs in describe_instances
1 participant