Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: refactor document for server mode (TestThreadedMotoServer) #6707

Merged

Conversation

jamesdongdong
Copy link
Contributor

@jamesdongdong jamesdongdong commented Aug 21, 2023

There is a disused method shown in docs/docs/server_mode.rst, which is .should.equal

it is better that using assertEqual instead of .should.equal

before

image

after

image

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - thanks for the PR @jamesdongdong!

@bblommers bblommers added this to the 4.1.15 milestone Aug 21, 2023
@bblommers bblommers changed the title refactor document for server mode (TestThreadedMotoServer) Docs: refactor document for server mode (TestThreadedMotoServer) Aug 21, 2023
@bblommers bblommers merged commit 8535e93 into getmoto:master Aug 21, 2023
@github-actions
Copy link
Contributor

This is now part of moto >= 4.1.15.dev101

toshyak pushed a commit to toshyak/moto that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants