Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glue] Implement batch_get_crawlers #5896

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

szemek
Copy link
Contributor

@szemek szemek commented Feb 1, 2023

Hello,
while working with moto I got NotImplementedError: The batch_get_crawlers action has not been implemented, so I decided to implement the missing method 😉
If you have any suggestions how to improve my code - please let me know!

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #5896 (c83d7c1) into master (75059fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5896   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         759      759           
  Lines       74768    74779   +11     
=======================================
+ Hits        71937    71951   +14     
+ Misses       2831     2828    -3     
Flag Coverage Δ
servertests 36.93% <9.09%> (-0.01%) ⬇️
unittests 96.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/glue/models.py 97.13% <100.00%> (+0.03%) ⬆️
moto/glue/responses.py 99.68% <100.00%> (+<0.01%) ⬆️
moto/batch/models.py 91.61% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding this feature @szemek!

@bblommers bblommers added this to the 4.1.2 milestone Feb 2, 2023
@bblommers bblommers merged commit 985bf4f into getmoto:master Feb 2, 2023
@szemek szemek deleted the batch_get_crawlers branch February 2, 2023 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This is now part of moto >= 4.1.2.dev19

viren-nadkarni pushed a commit to localstack/moto that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants