Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue: allow multiple job runs #5483

Merged

Conversation

bblommers
Copy link
Collaborator

See #5402

Also fixes the documentation to be inline with the actual implementation - the second argument for time-based progression should be seconds, not duration
Also fixes an import issue with S3, introduced in #5476

@bblommers bblommers added this to the 4.0.5 milestone Sep 16, 2022
@bblommers bblommers force-pushed the feature/glue-allow-multiple-job-runs branch 2 times, most recently from e2723f1 to fd55f51 Compare September 17, 2022 10:09
@bblommers bblommers force-pushed the feature/glue-allow-multiple-job-runs branch from fd55f51 to bf853b5 Compare September 17, 2022 10:56
@codecov-commenter
Copy link

Codecov Report

Merging #5483 (bf853b5) into master (5739db4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5483   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         724      724           
  Lines       72059    72070   +11     
=======================================
+ Hits        69250    69263   +13     
+ Misses       2809     2807    -2     
Flag Coverage Δ
servertests 37.10% <40.00%> (+<0.01%) ⬆️
unittests 96.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/glue/exceptions.py 99.24% <100.00%> (+0.01%) ⬆️
moto/glue/models.py 97.05% <100.00%> (+0.05%) ⬆️
moto/s3/models.py 96.18% <100.00%> (ø)
moto/iam/models.py 95.62% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bblommers bblommers merged commit 9fc64ad into getmoto:master Sep 17, 2022
@bblommers bblommers deleted the feature/glue-allow-multiple-job-runs branch September 17, 2022 11:46
@github-actions
Copy link
Contributor

This is now part of moto >= 4.0.4.dev12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants