ServerSideWebsite: Add Progress.create() arg for Serverless 4 compatibility

[nolotz]

Hi there,

With the release of Serverless 4, it appears that the ServerlessUtils progress.create() method now requires an initial argument to be passed. This is causing issues during deployment and any other time the uploadAssets() function is called.

Steps to Reproduce:

• Use Lift's ServerSideWebsite with Serverless 4.
• Trigger deployment or any action that calls the uploadAssets function.
• Observe the error due to the missing argument for progress.create().

Proposed Fix: Update the uploadAssets() function in ServerSideWebsite to pass an initial argument to progress.create() as follows:

uploadProgress = progress.create({
      message: 'Uploading assets'
});

Current Code Reference:

lift/src/constructs/aws/ServerSideWebsite.ts

Line 242 in 08772c5

uploadProgress = progress.create();

Documentation:
https://www.serverless.com/framework/docs/guides/plugins/cli-output#interactive-progress

Solves serverless/serverless#12797

Cheers,
Noah

[mnapoli]

Hi, is this backwards compatible with SF v3?

[nolotz]

Hi Antony, its basically the same and end user wouldn't notice.
SF 3.0.0 [1] is using SFU 6.0.0 [2] and since then progress.create supports message and name properties.

[1] https://github.com/serverless/utils/blob/v6.0.0/docs/log.md
[2] https://github.com/serverless/serverless/blob/v3.0.0/package.json

Cheers,
Noah

[mnapoli]

Thanks!