Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accept 0% as tax rate & throw error when rate not provided #121

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: accept 0% as tax rate & throw error when rate not provided #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eba056
fix: accept 0% as tax rate
rakeshkonni Aug 14, 2023
3c3d966
Merge branch 'getlago:main' into main
rakeshkonni Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tax.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ type TaxParams struct {
}

type TaxInput struct {
Name string `json:"name,omitempty"`
Code string `json:"code,omitempty"`
Rate float32 `json:"rate,omitempty"`
Description string `json:"description,omitempty"`
AppliedToOrganization bool `json:"applied_to_organization,omitempty"`
Name string `json:"name,omitempty"`
Code string `json:"code,omitempty"`
Rate *float32 `json:"rate,omitempty"`
Description string `json:"description,omitempty"`
AppliedToOrganization bool `json:"applied_to_organization,omitempty"`

CreatedAt time.Time `json:"created_at,omitempty"`
}
Expand All @@ -42,7 +42,7 @@ type Tax struct {
LagoID uuid.UUID `json:"lago_id,omitempty"`
Name string `json:"name,omitempty"`
Code string `json:"code,omitempty"`
Rate float32 `json:"rate"`
Rate float32 `json:"rate,omitempty"`
Description string `json:"description,omitempty"`
CustomersCount int `json:"customers_count,omitempty"`
PlansCount int `json:"plans_count,omitempty"`
Expand Down