-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Customer Portal v2 #1784
Merged
Merged
feat: Customer Portal v2 #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlago99
force-pushed
the
feat-customer-portal-v2
branch
3 times, most recently
from
October 8, 2024 11:03
c93bcde
to
d4ecf06
Compare
stephenlago99
force-pushed
the
feat-customer-portal-v2
branch
3 times, most recently
from
October 10, 2024 10:10
09457da
to
257fd6d
Compare
keellyp
reviewed
Oct 10, 2024
src/components/customerPortal/customerInformation/CustomerInformationPage.tsx
Outdated
Show resolved
Hide resolved
ansmonjol
reviewed
Oct 10, 2024
ansmonjol
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for handling all our comments! 🙌
keellyp
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far! Huge PR congrats for the work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request contains the new version of the Customer Portal.
Goals for the new version of the Customer Portal:
It also includes fixes after the first round of QA testing (commits starting with
LAGO-
).Description
Since this implementation required a refactoring of the existing CustomerPortal, this couldn't be split in multiple merge requests. There are new components that are used in multiple places, and separating it would have made the development process harder.
New components
Since the old Customer portal was missing some sections, some new components were developed for this:
To aid code share between them, some helper components were also created:
The design also facilitated the creation of reusable components, since design bits were re-used between sections and pages.
Refactoring of existing components
SearchInput
A new
className
param was added to aid tailwind styling.Subscription usage table / graph
src/components/subscriptions/SubscriptionCurrentUsageTable.tsx
src/components/subscriptions/SubscriptionUsageLifetimeGraph.tsx
Since the Usage part required us to display the usage table / graph, the existing components were refactored and de-coupled from the graphql queries.
New routes
The Customer Portal now includes a way to navigate between pages (in the previous implementation, we didn't have separate pages).
Besides the existing
CUSTOMER_PORTAL_ROUTE
, some new routes were added:For general pages:
export const CUSTOMER_PORTAL_ROUTE_PAGE = '/customer-portal/:token/:page'
For pages with items (like the usage section):
export const CUSTOMER_PORTAL_ROUTE_PAGE_ITEMID = '/customer-portal/:token/:page/:itemId'