Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: charge min amount should default to undefined if not set #1574

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

ansmonjol
Copy link
Collaborator

Context

We have a bug in the subscription form.

Each plan with a charge in advance makes the creatge subscription to create a plan override.

The reason is that FE sent 0 as a value when the field is set to undefined.

Description

This PR does

  • Make sure this does not happen anymore, and all '0' values are handled as undefined -> no plan override
  • Make sure if the user save a plan with an charge min amount, we dont populate the attribute with '0'

@ansmonjol ansmonjol added the 🐞 bug Something isn't working label Jun 28, 2024
@ansmonjol ansmonjol requested a review from keellyp June 28, 2024 13:39
@ansmonjol ansmonjol self-assigned this Jun 28, 2024
@ansmonjol ansmonjol merged commit 5a69708 into main Jun 28, 2024
5 checks passed
@ansmonjol ansmonjol deleted the charge-min-amount branch June 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants