Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add ability to rotate api key #2771

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

floganz
Copy link
Contributor

@floganz floganz commented Nov 1, 2024

Context

Another step toward API key management

Description

Decouple HMAC secret from API keys.
Add ability to instantly rotate API key.

@floganz floganz self-assigned this Nov 1, 2024
@floganz floganz force-pushed the feat-add-ability-to-rotate-api-key branch from 963cada to 6f59356 Compare November 4, 2024 09:20
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Not a blocker here, but do not hesitate to split pull request in small pieces as it helps with review.
For example, the api_key => hmac migration could be done in a separate PR.

@floganz floganz force-pushed the feat-add-ability-to-rotate-api-key branch from 6f59356 to ae3bd4e Compare November 5, 2024 09:53
@floganz floganz merged commit 2734962 into main Nov 5, 2024
6 checks passed
@floganz floganz deleted the feat-add-ability-to-rotate-api-key branch November 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants