feat(tax-integrations): Cover tax deduction case for tax integrations #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db/migrate/20240924114730_add_taxes_deduction_rate_fields_to_fees_and_applied_taxes.rb
Outdated
Show resolved
Hide resolved
lovrocolic
force-pushed
the
ftr-texas-case-anrok
branch
from
2fd9c4c
to
a262b57
Compare
lovrocolic
force-pushed
the
ftr-texas-case-anrok
branch
from
454bfc8
to
f0e6fd9
Compare
vincent-pochet
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Lago recently launched integration with tax provider Anrok.
Description
In some scenarios tax is not applied on the sum of all fees (with coupon applied).
Instead, there are scenarios where tax base is less than the sum of the fees (with coupon applied) and it depends mostly on the country (e.g. Texas in the USA).
This PR is covering described case.
tax_base_rateis included in tax logic and also used to display correct base in the UI/PDF.