misc: move invoice numbering outside DB transaction #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
approved these changes
Sep 23, 2024
vincent-pochet
approved these changes
Sep 24, 2024
lovrocolic
force-pushed
the
misc-upgrade-invoice-numbering
branch
from
1a0e72e
to
2d0e1a9
Compare
lovrocolic
force-pushed
the
misc-upgrade-invoice-numbering
branch
from
2d0e1a9
to
9ec2b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently invoice numbering requires locking scope on invoices table.
Description
This PR moves invoice numbering logic to the very end of the invoice generation process (outside DB transaction). With this approach, lock duration is decreased and it it less likely to face
SequenceError