Feat(anrok<>credit_notes) refactor CreditNotes::AppliedTax to search taxes by tax_code #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
feat-anrok-refactor-try
branch
from
90ed120
to
3951d28
Compare
annvelents
changed the base branch from
main
to
feat-anrok-cn-model-changes
annvelents
force-pushed
the
feat-anrok-refactor-try
branch
from
3951d28
to
e6f85d6
Compare
annvelents
changed the title
annvelents
force-pushed
the
feat-anrok-refactor-try
branch
from
a2e3f3e
to
8f3895f
Compare
vincent-pochet
approved these changes
Sep 11, 2024
annvelents
force-pushed
the
feat-anrok-refactor-try
branch
from
7e1a708
to
4a6913b
Compare
annvelents
force-pushed
the
feat-anrok-refactor-try
branch
from
4a6913b
to
71fd48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When we apply taxes on credit_notes, we're applying taxes that are stored for invoice - Invoice::AppliedTax. (and then we select taxes applied on fees, related to the credit_note_items)
Previous taxes implementation suggested that we should have a tax, saved in the db, so when iterating through taxes we were using tax.id, but currently taxes received from tax provider don't have a corresponding tax in the db, but we have tax_code, identifying the tax. the same is with stored in the db taxes: within the organization the tax_code will not be repeated, so if we start looking for taxes by tax_code instead of tax.id, we won't break existing logic and will adapt it to the new applied taxes that do not have taxes, stored in the db.
What was done:
Updated algorythm of searching taxes to apply on credit note, to search them by tax_code instead of tax_id