-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Discard Handling for AuthenticationError #2239
feat: Add Discard Handling for AuthenticationError #2239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL discard_on
I always rescued and ignore in perform. I like discard_on
much better.
Some other errors are handled here: Not sure but I think we should do the same things here rather than just silencing the error.
|
Co-authored-by: Vincent Pochet <[email protected]>
Context:
In this pull request, we change the error handling within the StripeCreateJob by discarding jobs that encounter Stripe::AuthenticationError. This change ensures that we prevent creating noise
Description:
Stripe::AuthenticationError
is raised, it indicates an issue with the authentication credentials. Since this is a non-recoverable error in the job context, retries are unnecessary.Additional Context:
update_payment_method_id
method in the related service sends a webhook notification when anyStripe::StripeError
is raised, ensuring customers are informed of issues promptly.