misc(sidekiq): New approach for cron monitoring

[vincent-pochet]

Context

This PR is a new approach to try to finally add cron monitoring on Sidekiq.
The logic was first introduced in #2109 and #1780

Description

The new approach uses ActiveJob.set to pass cron arguments to the job, in order to avoid the issues we faced lately with the initial approach

[julienbourdeau]

Just some food for thoughts, since these jobs are all in the Clock module and they are only called via clock.rb, we could store the sentry config directly in the job instead of using the class variable.
It could be a method or some constants.

module Clock
  class ActivateSubscriptionsJob < ApplicationJob
    include SentryCronConcern
    queue_as 'clock'

    unique :until_executed, on_conflict: :log

+    SENTRY_SLUG = :lago_activate_subscriptions
+    SENTRY_SCHEDULE = '*/5 * * * *'

    def perform
      Subscriptions::ActivateService.new(timestamp: Time.current.to_i).activate_all_pending
    end
    
+    def sentry
+      {slug: 'lago_activate_subscriptions', cron: '*/5 * * * *'}
+    end
  end
end

The drawback is that if you call the job manually, it would mess with the monitoring data 📊

[vincent-pochet]

Just some food for thoughts, since these jobs are all in the Clock module and they are only called via clock.rb, we could store the sentry config directly in the job instead of using the class variable. It could be a method or some constants.

module Clock
  class ActivateSubscriptionsJob < ApplicationJob
    include SentryCronConcern
    queue_as 'clock'

    unique :until_executed, on_conflict: :log

+    SENTRY_SLUG = :lago_activate_subscriptions
+    SENTRY_SCHEDULE = '*/5 * * * *'

    def perform
      Subscriptions::ActivateService.new(timestamp: Time.current.to_i).activate_all_pending
    end
    
+    def sentry
+      {slug: 'lago_activate_subscriptions', cron: '*/5 * * * *'}
+    end
  end
end

The drawback is that if you call the job manually, it would mess with the monitoring data 📊

There is also a risk of de-sync with what is configured in the clock file itself. The risk still exists in the current approach but at least it done in the same place