openapi3: fix format error when Header marshal to YAML #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in YAML the header has parameter field, but JSON does not.
fenollp
requested changes
Aug 8, 2023
| @@ -48,6 +48,11 @@ func (header *Header) UnmarshalJSON(data []byte) error { | |||
| return header.Parameter.UnmarshalJSON(data) | |||
| } | |||
|
|
|||
| // MarshalJSON returns the JSON encoding of Header. | |||
There was a problem hiding this comment.
Fix that and please add a couple lines of shell in ci next to the other checks if you can. Something comparing the counts of the two functions implemented with git grep. I can take care of it otherwise.
There was a problem hiding this comment.
sorry, i can't write the shell.
fenollp
added a commit
to fenollp/kin-openapi
that referenced
this pull request
Aug 26, 2023
Signed-off-by: Pierre Fenoll <[email protected]>
fenollp
added a commit
that referenced
this pull request
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in YAML the header has parameter field, but JSON does not.