Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Align module with latest Snowflake provider changes (removals and deprecations) #16

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

dpnoworyta
Copy link
Contributor

@dpnoworyta dpnoworyta commented Jul 19, 2024

This PR implements BREAKING CHANGES!!!

This PR completely rewrites the module, to align it with Snowflake provider latest versions (>0.90), implements some code optimizations and changes API (variables) in significant way.

List of changes:

  • Switched to snowflake_grant_ownership resource instead of provider-removed snowflake_role_ownership_grant

  • Switched to snowflake_database_role module to leverage new database_roles mechanism

  • default_roles and custom_roles are now combined and managed by single module

  • create_default_roles variable was renamed to create_default_database_roles

  • roles variable map received following additions:

    • all_privileges - optional, bool
    • on_all - optional, bool, defaults to false
    • on_future - optional, bool, defaults to false
    • with_grant_option - optional, bool
    • granted_to_database_roles - optional, string
    • granted_database_roles - optional, list of strings
  • and got following items removed:

    • comment
    • role_ownership_grant
    • granted_roles
    • granted_to_users

@dgniewek
Copy link
Contributor

Please take into account changes from this PR: getindata/terraform-snowflake-database-role#6

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
locals.tf Outdated Show resolved Hide resolved
@dpnoworyta dpnoworyta merged commit 637cc83 into main Jul 25, 2024
9 checks passed
Copy link

The new version v2.0.0 has been released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants