generated from getindata/terraform-module-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Align module with latest Snowflake provider changes (removals and deprecations) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpnoworyta
requested review from
jakubigla,
mariusz89016,
moss2k13,
dgniewek and
Santhin
July 19, 2024 10:25
Please take into account changes from this PR: getindata/terraform-snowflake-database-role#6 |
moss2k13
reviewed
Jul 23, 2024
moss2k13
reviewed
Jul 23, 2024
moss2k13
approved these changes
Jul 25, 2024
The new version v2.0.0 has been released 🎉 |
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements BREAKING CHANGES!!!
This PR completely rewrites the module, to align it with Snowflake provider latest versions (
>0.90
), implements some code optimizations and changes API (variables) in significant way.List of changes:
Switched to
snowflake_grant_ownership
resource instead of provider-removedsnowflake_role_ownership_grant
Switched to
snowflake_database_role
module to leverage newdatabase_roles
mechanismdefault_roles
andcustom_roles
are now combined and managed by single modulecreate_default_roles
variable was renamed tocreate_default_database_roles
roles
variable map received following additions:all_privileges
- optional, boolon_all
- optional, bool, defaults to falseon_future
- optional, bool, defaults to falsewith_grant_option
- optional, boolgranted_to_database_roles
- optional, stringgranted_database_roles
- optional, list of stringsand got following items removed:
comment
role_ownership_grant
granted_roles
granted_to_users