Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing logic needed to support on_all flag #10

Merged
merged 3 commits into from
Dec 28, 2023
Merged

fix: Add missing logic needed to support on_all flag #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fc1454
fix: missing logic updates for `on_all` support
dgniewek Dec 22, 2023
becf370
chore: add missing variable validation
dgniewek Dec 22, 2023
04729f8
Fix typo
dgniewek Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,13 @@ module "snowflake_role" {
privileges = ["SELECT"]
}
]

view_grants = [
{
database_name = "LOGS_DB"
schema_name = "BRONZE"
on_all = true
privileges = ["SELECT"]
}
]
}
13 changes: 9 additions & 4 deletions locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,39 +17,44 @@ locals {
}]...)

schema_grants = merge([for schema_grant in var.schema_grants : {
for privilege in schema_grant.privileges : "${schema_grant.database_name}/${schema_grant.schema_name}/${privilege}" => {
for privilege in schema_grant.privileges : "${schema_grant.database_name}/${coalesce(schema_grant.schema_name, schema_grant.on_future != null ? "on_future" : "on_all")}/${privilege}" => {
database_name = schema_grant.database_name
schema_name = schema_grant.schema_name
on_future = schema_grant.on_future
on_all = schema_grant.on_all
privilege = privilege
}
}]...)

table_grants = merge([for table_grant in var.table_grants : {
for privilege in table_grant.privileges : "${table_grant.database_name}/${table_grant.schema_name}/${coalesce(table_grant.table_name, "on_future")}/${privilege}" => {
for privilege in table_grant.privileges : "${table_grant.database_name}/${table_grant.schema_name}/${coalesce(table_grant.table_name, table_grant.on_future != null ? "on_future" : "on_all")}/${privilege}" => {
database_name = table_grant.database_name
schema_name = table_grant.schema_name
table_name = table_grant.table_name
on_future = table_grant.on_future
on_all = table_grant.on_all
privilege = privilege
}
}]...)

external_table_grants = merge([for table_grant in var.external_table_grants : {
for privilege in table_grant.privileges : "${table_grant.database_name}/${table_grant.schema_name}/${coalesce(table_grant.external_table_name, "on_future")}/${privilege}" => {
for privilege in table_grant.privileges : "${table_grant.database_name}/${table_grant.schema_name}/${coalesce(table_grant.external_table_name, table_grant.on_future != null ? "on_future" : "on_all")}/${privilege}" => {
database_name = table_grant.database_name
schema_name = table_grant.schema_name
external_table_name = table_grant.external_table_name
on_future = table_grant.on_future
on_all = table_grant.on_all
privilege = privilege
}
}]...)

view_grants = merge([for view_grant in var.view_grants : {
for privilege in view_grant.privileges : "${view_grant.database_name}/${view_grant.schema_name}/${coalesce(view_grant.view_name, "on_future")}/${privilege}" => {
for privilege in view_grant.privileges : "${view_grant.database_name}/${view_grant.schema_name}/${coalesce(view_grant.view_name, view_grant.on_future != null ? "on_future" : "on_all")}/${privilege}" => {
database_name = view_grant.database_name
schema_name = view_grant.schema_name
view_name = view_grant.view_name
on_future = view_grant.on_future
on_all = view_grant.on_all
privilege = privilege
}
}]...)
Expand Down
16 changes: 16 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ variable "schema_grants" {
on_future = optional(bool)
}))
default = []
validation {
condition = alltrue([for schema_grant in var.schema_grants : anytrue([schema_grant.schema_name != null, schema_grant.on_future, schema_grant.on_all])])
error_message = "Variable `schema_grants` fails validation - one of `schema_name`, `on_future` or `on_all` has to be set (not null / true)."
}
}

variable "table_grants" {
Expand All @@ -66,6 +70,10 @@ variable "table_grants" {
privileges = list(string)
}))
default = []
validation {
condition = alltrue([for table_grant in var.table_grants : anytrue([table_grant.table_name != null, table_grant.on_future, table_grant.on_all])])
error_message = "Variable `table_grants` fails validation - one of `table_name`, `on_future` or `on_all` has to be set (not null / true)."
}
}

variable "external_table_grants" {
Expand All @@ -79,6 +87,10 @@ variable "external_table_grants" {
privileges = list(string)
}))
default = []
validation {
condition = alltrue([for external_table_grant in var.external_table_grants : anytrue([external_table_grant.external_table_name != null, external_table_grant.on_future, external_table_grant.on_all])])
error_message = "Variable `external_table_grants` fails validation - one of `external_table_name`, `on_future` or `on_all` has to be set (not null / true)."
}
}

variable "view_grants" {
Expand All @@ -92,6 +104,10 @@ variable "view_grants" {
privileges = list(string)
}))
default = []
validation {
condition = alltrue([for view_grant in var.view_grants : anytrue([view_grant.view_name != null, view_grant.on_future, view_grant.on_all])])
error_message = "Variable `view_grants` fails validation - one of `view_name`, `on_future` or `on_all` has to be set (not null / true)."
}
}

variable "descriptor_name" {
Expand Down
Loading