feat: Align module with Snowflake provider changes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to breaking changes in Snowflake provider and additional code optimizations, **breaking changes** were introduced in this module. List of code and variable (API) changes: - Switched to `snowflake_database_role` module to leverage new `database_roles` mechanism - `default_roles` and `custom_roles` are now combined and controlled by single logic in snowflake_database_role module - snowflake_database resource was updated to use newly introduced changes in Snowflake provider - snowflake_schema resource was updated to use newly introduced changes in Snowflake provider - variable `add_grants_to_existing_objects` was removed as it is no longer needed - minimum Snowflake provider version is `0.90.0` For more information, refer to [variables.tf](variables.tf), list of inputs below and Snowflake provider documentation When upgrading from `v1.x`, expect most of the resources to be recreated - if recreation is impossible, then it is possible to import some existing resources.
moss2k13
commented
Jul 30, 2024
dgniewek
reviewed
Jul 31, 2024
terraform plugin is already available in tflint
moss2k13
changed the title
dgniewek
requested changes
Aug 1, 2024
dpnoworyta
reviewed
Aug 1, 2024
dgniewek
requested changes
Aug 2, 2024
dgniewek
requested changes
Aug 2, 2024
dgniewek
requested changes
Aug 5, 2024
dgniewek
approved these changes
Aug 5, 2024
|
The new version v2.0.0 has been released 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES IN v2.x.x
Due to breaking changes in Snowflake provider and additional code optimizations, breaking changes were introduced in
v2.0.0version of this module.List of code and variable (API) changes:
snowflake_database_rolemodule to leverage newdatabase_rolesmechanismdefault_rolesandcustom_rolesare now managed bygetindata/database_role/snowflakemoduleadd_grants_to_existing_objectswas removed as it is no longer needed0.90.0For more information, refer to variables.tf, list of inputs below and Snowflake provider documentation
When upgrading from
v1.x, expect most of the resources to be recreated - if recreation is impossible, then it is possible to import some existing resources.