Skip to content

Commit

Permalink
docs: Add comments about versions of tflint and pre-commit repo
Browse files Browse the repository at this point in the history
  • Loading branch information
kacpermuda committed Oct 16, 2023
1 parent 86cb6ee commit f33c592
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@ on:
jobs:
main:
uses: getindata/github-workflows/.github/workflows/[email protected]
with:
# tflint v0.46.0 is the latest version we can use with pre-commit v0.1.20
# See .pre-commit-config.yaml for more details.
tflint-version: v0.46.0
8 changes: 5 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
repos:
- repo: https://github.com/gruntwork-io/pre-commit
rev: "v0.1.22" # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
# Stick to v0.1.20 until this bug is fixed: https://github.com/gruntwork-io/pre-commit/issues/102
# When updating, also check if tflint version in pre-commit workflow can be updated.
rev: "v0.1.20" # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
hooks:
- id: terraform-validate # It should be before tflint hook as it runs terraform init required by tflint
- id: terraform-validate # It should be the first step as it runs terraform init required by tflint
- id: terraform-fmt
- id: tflint
args:
Expand All @@ -16,7 +18,7 @@ repos:
args: ["."]

- repo: https://github.com/bridgecrewio/checkov.git
rev: "2.5.6" # Get the latest from: https://github.com/bridgecrewio/checkov/releases
rev: "2.5.9" # Get the latest from: https://github.com/bridgecrewio/checkov/releases
hooks:
- id: checkov
args: [--skip-check, "CKV_TF_1"] # Terraform module sources do not use a git url with a commit hash revision
Expand Down

0 comments on commit f33c592

Please sign in to comment.