Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Switch nulllabel (context.tf) with context provider #8

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

dgniewek
Copy link
Collaborator

@dgniewek dgniewek commented Oct 30, 2024

BREAKING CHANGE
This PR introduces multiple braking changes to the module.

Changes:

  • Removed context.tf file (a single-file module with additonal variables), which implied a removal of all its variables (except name):
    • descriptor_formats
    • label_value_case
    • label_key_case
    • id_length_limit
    • regex_replace_chars
    • label_order
    • additional_tag_map
    • tags
    • labels_as_tags
    • attributes
    • delimiter
    • stage
    • environment
    • tenant
    • namespace
    • enabled
    • context
  • Remove support enabled flag - that might cause some backward compatibility issues with terraform state (please take into account that proper move clauses were added to minimize the impact), but proceed with caution
  • Additional context provider configuration
  • New variables were added, to allow naming configuration via context provider:
    • context_templates
    • name_schema

Additionally, the ability to grant database role to Snowflake Stage was added (not a braking change)

@dgniewek dgniewek requested a review from a team as a code owner October 30, 2024 15:11
jakubigla
jakubigla previously approved these changes Oct 30, 2024
.pre-commit-config.yaml Show resolved Hide resolved
@dgniewek dgniewek merged commit 1b770d6 into main Oct 31, 2024
8 checks passed
@dgniewek dgniewek deleted the feature/replace_nulllabel_with_context_provider branch October 31, 2024 14:40
Copy link

The new version v2.0.0 has been released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants