feat: Configure platform in infracost comment command #14
Conversation
main.tf
Outdated
| @@ -2,6 +2,12 @@ locals { | |||
| #Repo attributes that are meant to simplify configuration rather than being actual repo options | |||
| helper_options = ["allow_all_server_side_workflows", "terragrunt_atlantis_config", "infracost"] | |||
|
|
|||
| infracost_parameters = { | |||
| github : { token_name : "github-token", environment_variable_name : "GITHUB_TOKEN" }, | |||
There was a problem hiding this comment.
Was thinking to to change the variable names to be more specific INFRACOST_GITHUB_TOKEN etc. GITHUB_TOKEN is too generic and if we want to be more granual with permissions, we could then pass token with permissions to only post comments.
There was a problem hiding this comment.
yeah, you're right
(I was thinking about moving that environment_variable_name into variables (with default) but was worried about too many knobs there)
There was a problem hiding this comment.
yeah, very little value in exchange for possible technical debt
There was a problem hiding this comment.
IMO we should use atlantis token for infracost - I don't see any need to create and configure additional tokens.
Even more - I would suggest to "automate" infracost configuration a bit more - and instead of using infracost_parameters in the script - add few more lines of bash script and check which token is set in atlantis workspace and decide whether it is GitLab, GitHub or BitBucket.
mariusz89016
force-pushed
the
infracost-add-github-and-bitbucket
branch
from
5d15309 to
44ffedc
Compare
|
The new version v2.2.0 has been released 🎉 |
No description provided.