Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example terraform module #2

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Example terraform module #2

merged 2 commits into from
Jun 24, 2022

Conversation

dgniewek
Copy link
Contributor

Example terraform module using null-resource, with:

  • examples
  • terraform-docks
  • updated README
  • .gitignore

@dgniewek dgniewek requested a review from jakubigla June 15, 2022 13:09
jakubigla
jakubigla reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@jakubigla jakubigla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the naming convention for the module names and other bits?
Shouldn't we stick everywhere to the underscore? Happy to be convinced to the hyphens.

example/full-example/versions.tf Show resolved Hide resolved
@dgniewek dgniewek merged commit 753016a into main Jun 24, 2022
@kacpermuda kacpermuda deleted the example_module branch October 11, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubigla jakubigla jakubigla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgniewek @jakubigla