Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end tests #14

Merged
merged 23 commits into from
Mar 25, 2022
Merged

End to end tests #14

merged 23 commits into from
Mar 25, 2022

Conversation

em-pe
Copy link
Member

@em-pe em-pe commented Mar 24, 2022 •
edited
Loading

Description

Workflow that runs spaceflights scenario on our GCP infrastructure. Currently workflow is configured in a way, that runs only on develop branch, and proper PR's (not draft). We may review the costs of running tests later on.

Follow up tasks cover:

PR Checklist

@em-pe em-pe marked this pull request as ready for review March 24, 2022 21:43
@em-pe em-pe requested a review from marrrcin as a code owner March 24, 2022 21:43
@em-pe em-pe requested review from szczeles and mwiewior March 24, 2022 21:49
szczeles
szczeles reviewed Mar 25, 2022
View reviewed changes
.github/workflows/e2e-test.yml
echo "git+https://github.com/getindata/kedro-vertexai.git@$GITHUB_SHA" >> src/requirements.txt
echo "kedro-docker" >> src/requirements.txt
sed -i '/kedro-telemetry/d' src/requirements.txt
cat src/requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean this cat? I left it intentionally for debugging purposes

@szczeles
Copy link
Contributor

Impressive!!!

marrrcin
marrrcin approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@marrrcin marrrcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@em-pe em-pe force-pushed the end-to-end-tests branch from f3a5ee8 to edf752e Compare March 25, 2022 10:58
@em-pe em-pe merged commit b84450f into develop Mar 25, 2022
@em-pe em-pe deleted the end-to-end-tests branch March 25, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrrcin marrrcin marrrcin approved these changes

@szczeles szczeles szczeles approved these changes

@mwiewior mwiewior Awaiting requested review from mwiewior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@em-pe @szczeles @marrrcin