Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Support Gluetun widget auth #4034

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Tarow
Copy link
Contributor

@Tarow Tarow commented Sep 24, 2024

Proposed change

As of release v3.41.0, all Gluetun control server routes will be private by default as described here. The existing Gluetun widget implementation does not support authentication. This PR adds support for apikey auth for the widget and is related to #4026

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Collaborator

shamoon commented Sep 24, 2024

Please re-open when the threshold is met, thanks

@shamoon shamoon closed this Sep 24, 2024
@tikibozo
Copy link

@shamoon gluetun widgets for instances with auth configured are broken now, which will soon affect all gluetun instances. Maybe I should have opened it as a bug - do we wait until it breaks broadly and then merge, or can we merge now?

@shamoon
Copy link
Collaborator

shamoon commented Sep 24, 2024

Ok sure

@shamoon shamoon reopened this Sep 24, 2024
@shamoon shamoon marked this pull request as ready for review September 24, 2024 18:14
@shamoon shamoon changed the title Enhancement: Support Gluetun widget auth Fix: Support Gluetun widget auth Sep 24, 2024
@shamoon shamoon enabled auto-merge (squash) September 24, 2024 18:15
@shamoon shamoon merged commit 6da46dd into gethomepage:main Sep 24, 2024
7 checks passed
truecharts-admin referenced this pull request in truecharts/public Sep 27, 2024
…0.9.10@671c2ed by renovate (#26927)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://redirect.github.com/gethomepage/homepage)
| patch | `v0.9.9` -> `v0.9.10` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.10`](https://redirect.github.com/gethomepage/homepage/releases/tag/v0.9.10)

[Compare
Source](https://redirect.github.com/gethomepage/homepage/compare/v0.9.9...v0.9.10)

#### What's Changed

- Fix: handle proxmoxbackupserver without datastore by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3979](https://redirect.github.com/gethomepage/homepage/pull/3979)
- Fix: Technitium widget percentage display, occasional bug by
[@&#8203;bobby-driggs](https://redirect.github.com/bobby-driggs) in
[https://github.com/gethomepage/homepage/pull/3984](https://redirect.github.com/gethomepage/homepage/pull/3984)
- Enhancement: support another ghostfolio API breaking change by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3987](https://redirect.github.com/gethomepage/homepage/pull/3987)
- Feature: mailcow widget by
[@&#8203;grimsi](https://redirect.github.com/grimsi) in
[https://github.com/gethomepage/homepage/pull/3993](https://redirect.github.com/gethomepage/homepage/pull/3993)
- Enhancement: support pihole v6 with api auth disabled by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3995](https://redirect.github.com/gethomepage/homepage/pull/3995)
- Enhancement: reduce properties retrieved from mikrotik endpoint by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3996](https://redirect.github.com/gethomepage/homepage/pull/3996)
- Enhancement: support photoprism app passwords by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/4028](https://redirect.github.com/gethomepage/homepage/pull/4028)
- Feature: LubeLogger service widget by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/4031](https://redirect.github.com/gethomepage/homepage/pull/4031)
- Fix: Support Gluetun widget auth by
[@&#8203;Tarow](https://redirect.github.com/Tarow) in
[https://github.com/gethomepage/homepage/pull/4034](https://redirect.github.com/gethomepage/homepage/pull/4034)
- New Crowdin translations by GitHub Action by
[@&#8203;github-actions](https://redirect.github.com/github-actions) in
[https://github.com/gethomepage/homepage/pull/3980](https://redirect.github.com/gethomepage/homepage/pull/3980)
- Chore(deps-dev): Bump eslint-plugin-react from 7.35.2 to 7.36.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/4050](https://redirect.github.com/gethomepage/homepage/pull/4050)
- Chore(deps-dev): Bump tailwindcss from 3.4.10 to 3.4.13 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/4048](https://redirect.github.com/gethomepage/homepage/pull/4048)

**Full Changelog**:
gethomepage/homepage@v0.9.9...v0.9.10

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
jamesdkelly88 referenced this pull request in jamesdkelly88/db-lab Sep 27, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://redirect.github.com/gethomepage/homepage)
| patch | `v0.9.9` -> `v0.9.10` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.10`](https://redirect.github.com/gethomepage/homepage/releases/tag/v0.9.10)

[Compare
Source](https://redirect.github.com/gethomepage/homepage/compare/v0.9.9...v0.9.10)

#### What's Changed

- Fix: handle proxmoxbackupserver without datastore by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3979](https://redirect.github.com/gethomepage/homepage/pull/3979)
- Fix: Technitium widget percentage display, occasional bug by
[@&#8203;bobby-driggs](https://redirect.github.com/bobby-driggs) in
[https://github.com/gethomepage/homepage/pull/3984](https://redirect.github.com/gethomepage/homepage/pull/3984)
- Enhancement: support another ghostfolio API breaking change by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3987](https://redirect.github.com/gethomepage/homepage/pull/3987)
- Feature: mailcow widget by
[@&#8203;grimsi](https://redirect.github.com/grimsi) in
[https://github.com/gethomepage/homepage/pull/3993](https://redirect.github.com/gethomepage/homepage/pull/3993)
- Enhancement: support pihole v6 with api auth disabled by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3995](https://redirect.github.com/gethomepage/homepage/pull/3995)
- Enhancement: reduce properties retrieved from mikrotik endpoint by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3996](https://redirect.github.com/gethomepage/homepage/pull/3996)
- Enhancement: support photoprism app passwords by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/4028](https://redirect.github.com/gethomepage/homepage/pull/4028)
- Feature: LubeLogger service widget by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/4031](https://redirect.github.com/gethomepage/homepage/pull/4031)
- Fix: Support Gluetun widget auth by
[@&#8203;Tarow](https://redirect.github.com/Tarow) in
[https://github.com/gethomepage/homepage/pull/4034](https://redirect.github.com/gethomepage/homepage/pull/4034)
- New Crowdin translations by GitHub Action by
[@&#8203;github-actions](https://redirect.github.com/github-actions) in
[https://github.com/gethomepage/homepage/pull/3980](https://redirect.github.com/gethomepage/homepage/pull/3980)
- Chore(deps-dev): Bump eslint-plugin-react from 7.35.2 to 7.36.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/4050](https://redirect.github.com/gethomepage/homepage/pull/4050)
- Chore(deps-dev): Bump tailwindcss from 3.4.10 to 3.4.13 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/4048](https://redirect.github.com/gethomepage/homepage/pull/4048)

**Full Changelog**:
gethomepage/homepage@v0.9.9...v0.9.10

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/jamesdkelly88/db-lab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants