Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Linkwarden service widget #3836

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

PyrokineticDarkElf
Copy link
Contributor

@PyrokineticDarkElf PyrokineticDarkElf commented Aug 9, 2024

Proposed change

Minimal version of #3832

These changes remove everything except the stats fields:
image

Relevant API responses:

/api/v1/collections:

{
    "response": [
        {
            "id": 8,
            "name": "Homelab",
            "description": "",
            "color": "#ff0000",
            "parentId": null,
            "isPublic": false,
            "ownerId": 1,
            "createdAt": "2024-04-18T21:45:13.843Z",
            "updatedAt": "2024-04-18T21:45:13.843Z",
            "parent": null,
            "members": [],
            "_count": {
                "links": 24
            }
        }
    ]
}

/api/v1/tags:

{
    "response": [
        {
            "id": 118,
            "name": "HTML",
            "ownerId": 1,
            "createdAt": "2024-04-19T09:20:56.287Z",
            "updatedAt": "2024-04-19T09:20:56.287Z",
            "_count": {
                "links": 1
            }
        }
    ]
}

Notes:

I had to disable no-underscore-dangle in ESLint using comments due to API constraints.

/* eslint-disable no-underscore-dangle */
Some code
/* eslint-enable no-underscore-dangle */

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon changed the title Minimal version of Linkwarden integration Feature: Linkwarden service widget Aug 9, 2024
@shamoon shamoon enabled auto-merge (squash) August 9, 2024 21:18
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for modifying this PR, ill close the other.

So, my guess is you generated this using AI, so a few things:

  1. The code is messy and un-human (consts for things that are used 1 time).
  2. The proxy here is completely unnecessary, the screenshot below is with it removed.
  3. We ask that people disclose when they do this because of these quality issues.

In general it's ok to use AI as a starting point but it really needs to be managed carefully. Also, I dont mean this disrespectfully at all but it's sort of disappointing when reviewing a PR is actually more work than creating it from scratch. Definitely something to keep in mind if youre planning to open PRs in other projects.

Screenshot 2024-08-09 at 2 03 43 PM

I went ahead and pushed the changes rather than request them all. Thanks for your interest in the project

@shamoon shamoon merged commit 4d38222 into gethomepage:main Aug 9, 2024
5 checks passed
truecharts-admin referenced this pull request in truecharts/public Aug 11, 2024
…0.9.6@e5b2616 by renovate (#25014)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.9.5` -> `v0.9.6` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.6`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.6)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.5...v0.9.6)

#### What's Changed

- Fix: wg-easy widget show o.filter is not a function when wg-easy api
return error by [@&#8203;BugGeeker](https://togithub.com/BugGeeker) in
[https://github.com/gethomepage/homepage/pull/3768](https://togithub.com/gethomepage/homepage/pull/3768)
- Fix: correctly decode tab names with special chars by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3797](https://togithub.com/gethomepage/homepage/pull/3797)
- Chore(deps): Bump systeminformation from 5.22.7 to 5.23.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3799](https://togithub.com/gethomepage/homepage/pull/3799)
- Chore(deps-dev): Bump eslint-plugin-prettier from 4.2.1 to 5.2.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3802](https://togithub.com/gethomepage/homepage/pull/3802)
- Chore(deps): Bump urbackup-server-api from 0.8.9 to 0.52.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3801](https://togithub.com/gethomepage/homepage/pull/3801)
- Chore(deps): Bump raw-body from 2.5.2 to 3.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3803](https://togithub.com/gethomepage/homepage/pull/3803)
- Change: handle errored truenas pools by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3815](https://togithub.com/gethomepage/homepage/pull/3815)
- Feature: Linkwarden service widget by
[@&#8203;PyrokineticDarkElf](https://togithub.com/PyrokineticDarkElf)
and [@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3836](https://togithub.com/gethomepage/homepage/pull/3836)
- Enhancement: use tubearchivist stats endpoints by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3814](https://togithub.com/gethomepage/homepage/pull/3814)

#### New Contributors

- [@&#8203;BugGeeker](https://togithub.com/BugGeeker) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3768](https://togithub.com/gethomepage/homepage/pull/3768)
- [@&#8203;PyrokineticDarkElf](https://togithub.com/PyrokineticDarkElf)
made their first contribution in
[https://github.com/gethomepage/homepage/pull/3836](https://togithub.com/gethomepage/homepage/pull/3836)

**Full Changelog**:
gethomepage/homepage@v0.9.5...v0.9.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNS4wIiwidXBkYXRlZEluVmVyIjoiMzguMjUuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
jamesdkelly88 referenced this pull request in jamesdkelly88/db-lab Sep 4, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://redirect.github.com/gethomepage/homepage)
| patch | `v0.9.2` -> `v0.9.6` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.6`](https://redirect.github.com/gethomepage/homepage/releases/tag/v0.9.6)

[Compare
Source](https://redirect.github.com/gethomepage/homepage/compare/v0.9.5...v0.9.6)

#### What's Changed

- Fix: wg-easy widget show o.filter is not a function when wg-easy api
return error by
[@&#8203;BugGeeker](https://redirect.github.com/BugGeeker) in
[https://github.com/gethomepage/homepage/pull/3768](https://redirect.github.com/gethomepage/homepage/pull/3768)
- Fix: correctly decode tab names with special chars by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3797](https://redirect.github.com/gethomepage/homepage/pull/3797)
- Chore(deps): Bump systeminformation from 5.22.7 to 5.23.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3799](https://redirect.github.com/gethomepage/homepage/pull/3799)
- Chore(deps-dev): Bump eslint-plugin-prettier from 4.2.1 to 5.2.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3802](https://redirect.github.com/gethomepage/homepage/pull/3802)
- Chore(deps): Bump urbackup-server-api from 0.8.9 to 0.52.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3801](https://redirect.github.com/gethomepage/homepage/pull/3801)
- Chore(deps): Bump raw-body from 2.5.2 to 3.0.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3803](https://redirect.github.com/gethomepage/homepage/pull/3803)
- Change: handle errored truenas pools by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3815](https://redirect.github.com/gethomepage/homepage/pull/3815)
- Feature: Linkwarden service widget by
[@&#8203;PyrokineticDarkElf](https://redirect.github.com/PyrokineticDarkElf)
and [@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3836](https://redirect.github.com/gethomepage/homepage/pull/3836)
- Enhancement: use tubearchivist stats endpoints by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3814](https://redirect.github.com/gethomepage/homepage/pull/3814)

#### New Contributors

- [@&#8203;BugGeeker](https://redirect.github.com/BugGeeker) made their
first contribution in
[https://github.com/gethomepage/homepage/pull/3768](https://redirect.github.com/gethomepage/homepage/pull/3768)
-
[@&#8203;PyrokineticDarkElf](https://redirect.github.com/PyrokineticDarkElf)
made their first contribution in
[https://github.com/gethomepage/homepage/pull/3836](https://redirect.github.com/gethomepage/homepage/pull/3836)

**Full Changelog**:
gethomepage/homepage@v0.9.5...v0.9.6

###
[`v0.9.5`](https://redirect.github.com/gethomepage/homepage/releases/tag/v0.9.5)

[Compare
Source](https://redirect.github.com/gethomepage/homepage/compare/v0.9.4...v0.9.5)

#### What's Changed

- Fix: correct k8s service status check from v0.9.4 by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3753](https://redirect.github.com/gethomepage/homepage/pull/3753)
- Enhancement: support pfsense v2 api by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3716](https://redirect.github.com/gethomepage/homepage/pull/3716)
- Feature: Frigate service widget by
[@&#8203;j0ton](https://redirect.github.com/j0ton) in
[https://github.com/gethomepage/homepage/pull/3743](https://redirect.github.com/gethomepage/homepage/pull/3743)

**Full Changelog**:
gethomepage/homepage@v0.9.3...v0.9.5

###
[`v0.9.4`](https://redirect.github.com/gethomepage/homepage/compare/v0.9.3...v0.9.4)

[Compare
Source](https://redirect.github.com/gethomepage/homepage/compare/v0.9.3...v0.9.4)

###
[`v0.9.3`](https://redirect.github.com/gethomepage/homepage/releases/tag/v0.9.3)

[Compare
Source](https://redirect.github.com/gethomepage/homepage/compare/v0.9.2...v0.9.3)

#### What's Changed

- Fix: dont force lowercase URL in QuickLaunch by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3634](https://redirect.github.com/gethomepage/homepage/pull/3634)
- Fix: Improve error handling for Glances widgets by
[@&#8203;mjsully](https://redirect.github.com/mjsully) and
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3657](https://redirect.github.com/gethomepage/homepage/pull/3657)
- Feature: MySpeed widget by
[@&#8203;gnmyt](https://redirect.github.com/gnmyt) and
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3662](https://redirect.github.com/gethomepage/homepage/pull/3662)
- Fix: Sort truenas pools by name by
[@&#8203;marktitorenkov](https://redirect.github.com/marktitorenkov) and
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3669](https://redirect.github.com/gethomepage/homepage/pull/3669)
- Fix: search dropdown overlay with boxedheaders option by
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3680](https://redirect.github.com/gethomepage/homepage/pull/3680)
- Feature: stock market service and info widget by
[@&#8203;eldyl](https://redirect.github.com/eldyl) and
[@&#8203;shamoon](https://redirect.github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3617](https://redirect.github.com/gethomepage/homepage/pull/3617)

#### New Contributors

- [@&#8203;mjsully](https://redirect.github.com/mjsully) made their
first contribution in
[https://github.com/gethomepage/homepage/pull/3657](https://redirect.github.com/gethomepage/homepage/pull/3657)
- [@&#8203;gnmyt](https://redirect.github.com/gnmyt) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3662](https://redirect.github.com/gethomepage/homepage/pull/3662)
- [@&#8203;marktitorenkov](https://redirect.github.com/marktitorenkov)
made their first contribution in
[https://github.com/gethomepage/homepage/pull/3669](https://redirect.github.com/gethomepage/homepage/pull/3669)
- [@&#8203;eldyl](https://redirect.github.com/eldyl) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3617](https://redirect.github.com/gethomepage/homepage/pull/3617)

**Full Changelog**:
gethomepage/homepage@v0.9.2...v0.9.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/jamesdkelly88/db-lab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Plancke pushed a commit to Plancke/homepage that referenced this pull request Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants