Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes services incorrectly marked as down #3752

Closed
wants to merge 1 commit into from

Conversation

ThisIsQasim
Copy link

@ThisIsQasim ThisIsQasim commented Jul 18, 2024

Proposed change

After 0.9.4 was pushed, all kubernetes services are incorrectly marked as down. This fixes the issue by removing the in operator which works differently in JavaScript

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

the "in" operator works differently in JavaScript
@shamoon
Copy link
Collaborator

shamoon commented Jul 18, 2024

Ha, we literally did that at the same moment, thanks tho. See #3753

@shamoon shamoon closed this Jul 18, 2024
@ThisIsQasim ThisIsQasim deleted the patch-1 branch July 18, 2024 06:13
@ThisIsQasim
Copy link
Author

lol. Thanks for great work!

Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants