Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Frigate service widget #3743

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Feature: Frigate service widget #3743

merged 9 commits into from
Jul 17, 2024

Conversation

j0ton
Copy link
Contributor

@j0ton j0ton commented Jul 15, 2024

Proposed change

Implemented a new Frigate service widget (Feature Request #2857)

Screenshot 2024-07-15 at 8 34 24 PM

Example with enableRecentEvents option set to true:

Screenshot 2024-07-15 at 8 33 54 PM

Example of event thumbnail preview on hovering over event:

Screenshot 2024-07-15 at 8 35 13 PM

Closes #2857

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@j0ton j0ton marked this pull request as ready for review July 15, 2024 09:06
@shamoon
Copy link
Collaborator

shamoon commented Jul 15, 2024

Thanks. Please post some example api output for us to test with. And I think the thumbnail part will have to be removed, it really doesn’t comply with our guidelines and we really emphasize consistency

@narsaw
Copy link

narsaw commented Jul 15, 2024

Homepage Dev please consider leaving in the thumbnail feature. ITs a really big deal to have this feature.

@shamoon
Copy link
Collaborator

shamoon commented Jul 15, 2024

Homepage is not designed to be a "Swiss-army knife" single tool to replace everything, the widget features are to get a glance into other tools. The thumbnail should be removed. Presumably those events can link to somewhere else, that would be ok.

@j0ton
Copy link
Contributor Author

j0ton commented Jul 15, 2024

Thanks. Please post some example api output for us to test with. And I think the thumbnail part will have to be removed, it really doesn’t comply with our guidelines and we really emphasize consistency

OK no problem I'll remove the thumbnail and possibly look at linking to the events.
I've attached output for the 2 api calls used: /api/stats and /api/events
stats.json
events.json

shamoon
shamoon requested changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. couple small things and I still need to test

src/widgets/frigate/component.jsx Outdated Show resolved Hide resolved
src/widgets/frigate/component.jsx Outdated Show resolved Hide resolved
public/locales/en/common.json Outdated Show resolved Hide resolved
@shamoon shamoon enabled auto-merge (squash) July 17, 2024 14:08
shamoon
shamoon approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

Screenshot 2024-07-17 at 7 06 02 AM

@shamoon shamoon merged commit 16b45a3 into gethomepage:main Jul 17, 2024
5 checks passed
@j0ton j0ton deleted the feature/frigate-widget branch July 18, 2024 10:03
truecharts-admin referenced this pull request in truecharts/public Jul 24, 2024
@truecharts-admin
chore(deps): update container image ghcr.io/gethomepage/homepage to v…
33ed6b6 
…0.9.5@e23fcd3 by renovate (#24087)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.9.2` -> `v0.9.5` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.5`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.5)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.4...v0.9.5)

#### What's Changed

- Fix: correct k8s service status check from v0.9.4 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3753](https://togithub.com/gethomepage/homepage/pull/3753)
- Enhancement: support pfsense v2 api by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3716](https://togithub.com/gethomepage/homepage/pull/3716)
- Feature: Frigate service widget by
[@&#8203;j0ton](https://togithub.com/j0ton) in
[https://github.com/gethomepage/homepage/pull/3743](https://togithub.com/gethomepage/homepage/pull/3743)

**Full Changelog**:
gethomepage/homepage@v0.9.3...v0.9.5

###
[`v0.9.4`](https://togithub.com/gethomepage/homepage/compare/v0.9.3...v0.9.4)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.3...v0.9.4)

###
[`v0.9.3`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.3)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.2...v0.9.3)

#### What's Changed

- Fix: dont force lowercase URL in QuickLaunch by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3634](https://togithub.com/gethomepage/homepage/pull/3634)
- Fix: Improve error handling for Glances widgets by
[@&#8203;mjsully](https://togithub.com/mjsully) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3657](https://togithub.com/gethomepage/homepage/pull/3657)
- Feature: MySpeed widget by [@&#8203;gnmyt](https://togithub.com/gnmyt)
and [@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3662](https://togithub.com/gethomepage/homepage/pull/3662)
- Fix: Sort truenas pools by name by
[@&#8203;marktitorenkov](https://togithub.com/marktitorenkov) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3669](https://togithub.com/gethomepage/homepage/pull/3669)
- Fix: search dropdown overlay with boxedheaders option by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3680](https://togithub.com/gethomepage/homepage/pull/3680)
- Feature: stock market service and info widget by
[@&#8203;eldyl](https://togithub.com/eldyl) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3617](https://togithub.com/gethomepage/homepage/pull/3617)

#### New Contributors

- [@&#8203;mjsully](https://togithub.com/mjsully) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3657](https://togithub.com/gethomepage/homepage/pull/3657)
- [@&#8203;gnmyt](https://togithub.com/gnmyt) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3662](https://togithub.com/gethomepage/homepage/pull/3662)
- [@&#8203;marktitorenkov](https://togithub.com/marktitorenkov) made
their first contribution in
[https://github.com/gethomepage/homepage/pull/3669](https://togithub.com/gethomepage/homepage/pull/3669)
- [@&#8203;eldyl](https://togithub.com/eldyl) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3617](https://togithub.com/gethomepage/homepage/pull/3617)

**Full Changelog**:
gethomepage/homepage@v0.9.2...v0.9.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC42IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j0ton @shamoon @narsaw