-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: coinmarketcap widget dropdown not clickable #3591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamoon
changed the title
Fix dropdown of coinmarketcap widget
Fix: coinmarketcap widget dropdown not clickable
Jun 5, 2024
shamoon
approved these changes
Jun 5, 2024
truecharts-admin
referenced
this pull request
in truecharts/public
Jun 6, 2024
…0.9.2@5356c97 by renovate (#22920) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.9.1` -> `v0.9.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2) #### What's Changed #### Security - This release addresses a vulnerability that could allow leakage of API keys from weather widgets, see https://github.com/gethomepage/homepage/security/advisories/GHSA-cjgf-vhj6-8cx4 . Thanks to Kwstubbs for reporting. #### App changes - Fix: caddy widget broken in v0.9.1 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3579](https://togithub.com/gethomepage/homepage/pull/3579) - Fix: omada widget broken in v0.9.1 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3587](https://togithub.com/gethomepage/homepage/pull/3587) - Fix/handle null id in json rpc responses and cpu load representation for openwrt widget by [@​LiranV](https://togithub.com/LiranV) in [https://github.com/gethomepage/homepage/pull/3576](https://togithub.com/gethomepage/homepage/pull/3576) - Fix: wg-easy threshold not properly computed by [@​ConnerWithAnE](https://togithub.com/ConnerWithAnE) in [https://github.com/gethomepage/homepage/pull/3574](https://togithub.com/gethomepage/homepage/pull/3574) - Enhancement: support multiple instance annotation for Kubernetes Automatic Service Discovery by [@​aldycool](https://togithub.com/aldycool) in [https://github.com/gethomepage/homepage/pull/3590](https://togithub.com/gethomepage/homepage/pull/3590) - Fix: coinmarketcap widget dropdown not clickable by [@​henry40408](https://togithub.com/henry40408) in [https://github.com/gethomepage/homepage/pull/3591](https://togithub.com/gethomepage/homepage/pull/3591) #### New Contributors - [@​LiranV](https://togithub.com/LiranV) made their first contribution in [https://github.com/gethomepage/homepage/pull/3576](https://togithub.com/gethomepage/homepage/pull/3576) - [@​aldycool](https://togithub.com/aldycool) made their first contribution in [https://github.com/gethomepage/homepage/pull/3590](https://togithub.com/gethomepage/homepage/pull/3590) **Full Changelog**: gethomepage/homepage@v0.9.1...v0.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
szinn
referenced
this pull request
in szinn/k8s-homelab
Jun 6, 2024
…v0.9.2 ) (#3790) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.9.1` -> `v0.9.2` | --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2) #### What's Changed #### Security - This release addresses a vulnerability that could allow leakage of API keys from weather widgets, see https://github.com/gethomepage/homepage/security/advisories/GHSA-cjgf-vhj6-8cx4 . Thanks to Kwstubbs for reporting. #### App changes - Fix: caddy widget broken in v0.9.1 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3579](https://togithub.com/gethomepage/homepage/pull/3579) - Fix: omada widget broken in v0.9.1 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3587](https://togithub.com/gethomepage/homepage/pull/3587) - Fix/handle null id in json rpc responses and cpu load representation for openwrt widget by [@​LiranV](https://togithub.com/LiranV) in [https://github.com/gethomepage/homepage/pull/3576](https://togithub.com/gethomepage/homepage/pull/3576) - Fix: wg-easy threshold not properly computed by [@​ConnerWithAnE](https://togithub.com/ConnerWithAnE) in [https://github.com/gethomepage/homepage/pull/3574](https://togithub.com/gethomepage/homepage/pull/3574) - Enhancement: support multiple instance annotation for Kubernetes Automatic Service Discovery by [@​aldycool](https://togithub.com/aldycool) in [https://github.com/gethomepage/homepage/pull/3590](https://togithub.com/gethomepage/homepage/pull/3590) - Fix: coinmarketcap widget dropdown not clickable by [@​henry40408](https://togithub.com/henry40408) in [https://github.com/gethomepage/homepage/pull/3591](https://togithub.com/gethomepage/homepage/pull/3591) #### New Contributors - [@​LiranV](https://togithub.com/LiranV) made their first contribution in [https://github.com/gethomepage/homepage/pull/3576](https://togithub.com/gethomepage/homepage/pull/3576) - [@​aldycool](https://togithub.com/aldycool) made their first contribution in [https://github.com/gethomepage/homepage/pull/3590](https://togithub.com/gethomepage/homepage/pull/3590) **Full Changelog**: gethomepage/homepage@v0.9.1...v0.9.2 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
Jun 8, 2024
…785) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | minor | `v0.8.13` -> `v0.9.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2) #### What's Changed #### Security - This release addresses a vulnerability that could allow leakage of API keys from weather widgets. #### App changes - Fix: caddy widget broken in v0.9.1 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3579](https://togithub.com/gethomepage/homepage/pull/3579) - Fix: omada widget broken in v0.9.1 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3587](https://togithub.com/gethomepage/homepage/pull/3587) - Fix/handle null id in json rpc responses and cpu load representation for openwrt widget by [@​LiranV](https://togithub.com/LiranV) in [https://github.com/gethomepage/homepage/pull/3576](https://togithub.com/gethomepage/homepage/pull/3576) - Fix: wg-easy threshold not properly computed by [@​ConnerWithAnE](https://togithub.com/ConnerWithAnE) in [https://github.com/gethomepage/homepage/pull/3574](https://togithub.com/gethomepage/homepage/pull/3574) - Enhancement: support multiple instance annotation for Kubernetes Automatic Service Discovery by [@​aldycool](https://togithub.com/aldycool) in [https://github.com/gethomepage/homepage/pull/3590](https://togithub.com/gethomepage/homepage/pull/3590) - Fix: coinmarketcap widget dropdown not clickable by [@​henry40408](https://togithub.com/henry40408) in [https://github.com/gethomepage/homepage/pull/3591](https://togithub.com/gethomepage/homepage/pull/3591) #### New Contributors - [@​LiranV](https://togithub.com/LiranV) made their first contribution in [https://github.com/gethomepage/homepage/pull/3576](https://togithub.com/gethomepage/homepage/pull/3576) - [@​aldycool](https://togithub.com/aldycool) made their first contribution in [https://github.com/gethomepage/homepage/pull/3590](https://togithub.com/gethomepage/homepage/pull/3590) **Full Changelog**: gethomepage/homepage@v0.9.1...v0.9.2 ### [`v0.9.1`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.1) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.13...v0.9.1) #### What's Changed *Note: version 0.9.0 contained a few issues and did not completely resolve the security issue, it has been removed and all users are recommended to upgrade to v0.9.1* ##### Security - This version resolves security vulnerabilities discovered in some integrations, see GHSA-24m5-7vjx-9x37. Thanks to kachakil-av for reporting. ##### Other Changes - Fix: calendar integration broken in v0.9.0 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3565](https://togithub.com/gethomepage/homepage/pull/3565) - Fix: glances cpu metric broken in v0.9.0 by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3566](https://togithub.com/gethomepage/homepage/pull/3566) - Fix: handle ghostfolio v2.79.0 breaking API changes by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3471](https://togithub.com/gethomepage/homepage/pull/3471) - Fix: allow exclamation to open quicklaunch by [@​jesusmlopezf](https://togithub.com/jesusmlopezf) in [https://github.com/gethomepage/homepage/pull/3475](https://togithub.com/gethomepage/homepage/pull/3475) - Feature: Wg-Easy Widget by [@​ConnerWithAnE](https://togithub.com/ConnerWithAnE) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3476](https://togithub.com/gethomepage/homepage/pull/3476) - Change icon in the longhorn widget to use the same as resources by [@​nick-disiere](https://togithub.com/nick-disiere) in [https://github.com/gethomepage/homepage/pull/3509](https://togithub.com/gethomepage/homepage/pull/3509) - Feature: SWAG dashboard widget by [@​quietsy](https://togithub.com/quietsy) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3523](https://togithub.com/gethomepage/homepage/pull/3523) - Chore(deps): Bump crowdin/github-action from 1 to 2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3537](https://togithub.com/gethomepage/homepage/pull/3537) - Fix: remove comma in Caddy and EVCC widgets by [@​grimsi](https://togithub.com/grimsi) in [https://github.com/gethomepage/homepage/pull/3551](https://togithub.com/gethomepage/homepage/pull/3551) - Enhancement: separate Internet search settings for quicklaunch by [@​vycdev](https://togithub.com/vycdev) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3541](https://togithub.com/gethomepage/homepage/pull/3541) - Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3554](https://togithub.com/gethomepage/homepage/pull/3554) - Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3555](https://togithub.com/gethomepage/homepage/pull/3555) #### New Contributors - [@​jesusmlopezf](https://togithub.com/jesusmlopezf) made their first contribution in [https://github.com/gethomepage/homepage/pull/3475](https://togithub.com/gethomepage/homepage/pull/3475) - [@​ConnerWithAnE](https://togithub.com/ConnerWithAnE) made their first contribution in [https://github.com/gethomepage/homepage/pull/3476](https://togithub.com/gethomepage/homepage/pull/3476) - [@​nick-disiere](https://togithub.com/nick-disiere) made their first contribution in [https://github.com/gethomepage/homepage/pull/3509](https://togithub.com/gethomepage/homepage/pull/3509) - [@​quietsy](https://togithub.com/quietsy) made their first contribution in [https://github.com/gethomepage/homepage/pull/3523](https://togithub.com/gethomepage/homepage/pull/3523) - [@​vycdev](https://togithub.com/vycdev) made their first contribution in [https://github.com/gethomepage/homepage/pull/3541](https://togithub.com/gethomepage/homepage/pull/3541) **Full Changelog**: gethomepage/homepage@v0.8.13...v0.9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix drop-down of CoinMarketCap widget:
Currently, the drop-down is not clickable because its z-index is set to
auto
, while the title bar (.service-name
) of the widget has a z-index of10
(z-10). As a result, the drop-down is shadowed by the title bar. This pull request sets the z-index of the drop-down to20
(z-20), the next higher z-index class name I found in TailwindCSS, making the drop-down clickable again.Type of change
Checklist:
Tested on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:126.0) Gecko/20100101 Firefox/126.0