Enhancement: add bitrate precision config option for speedtest-tracker #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…speedtest-tracker
ameerabdallah
commented
Apr 23, 2024
shamoon
requested changes
Apr 23, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
shamoon
changed the title
auto-merge was automatically disabled
April 23, 2024 03:38
Head branch was pushed to by a user without write access
shamoon
changed the title
ameerabdallah
deleted the
feature/speedtest-tracker-widget-download-upload-number-formatting
branch
|
You don’t have privileges to review PRs, and this PR is already merged… |
szinn
referenced
this pull request
in szinn/k8s-homelab
May 6, 2024
… v0.8.13 ) (#3607) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.12` -> `v0.8.13` | --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.13`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.13) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.12...v0.8.13) #### What's Changed - Enhancement: configurable CPU temp scale by [@​daviddavid](https://togithub.com/daviddavid) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3332](https://togithub.com/gethomepage/homepage/pull/3332) - Enhancement: additional tautulli jellyfin emby configuration options by [@​ameerabdallah](https://togithub.com/ameerabdallah) in [https://github.com/gethomepage/homepage/pull/3350](https://togithub.com/gethomepage/homepage/pull/3350) - Enhancement: add bitrate precision config option for speedtest-tracker by [@​ameerabdallah](https://togithub.com/ameerabdallah) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3354](https://togithub.com/gethomepage/homepage/pull/3354) - Fix: format Romm statistics by [@​EdwardSalter](https://togithub.com/EdwardSalter) in [https://github.com/gethomepage/homepage/pull/3358](https://togithub.com/gethomepage/homepage/pull/3358) - Fix some unsanitized error URLs by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3385](https://togithub.com/gethomepage/homepage/pull/3385) - Chore(deps): Bump recharts from 2.12.3 to 2.12.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3397](https://togithub.com/gethomepage/homepage/pull/3397) - Chore(deps-dev): Bump typescript from 4.9.5 to 5.4.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3396](https://togithub.com/gethomepage/homepage/pull/3396) - Chore(deps): Bump systeminformation from 5.22.0 to 5.22.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3398](https://togithub.com/gethomepage/homepage/pull/3398) - Chore(deps): Bump react from 18.2.0 to 18.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3400](https://togithub.com/gethomepage/homepage/pull/3400) - Chore(deps-dev): Bump eslint-config-next from 12.3.4 to 14.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3399](https://togithub.com/gethomepage/homepage/pull/3399) #### New Contributors - [@​daviddavid](https://togithub.com/daviddavid) made their first contribution in [https://github.com/gethomepage/homepage/pull/3332](https://togithub.com/gethomepage/homepage/pull/3332) - [@​ameerabdallah](https://togithub.com/ameerabdallah) made their first contribution in [https://github.com/gethomepage/homepage/pull/3350](https://togithub.com/gethomepage/homepage/pull/3350) - [@​EdwardSalter](https://togithub.com/EdwardSalter) made their first contribution in [https://github.com/gethomepage/homepage/pull/3358](https://togithub.com/gethomepage/homepage/pull/3358) **Full Changelog**: gethomepage/homepage@v0.8.12...v0.8.13 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDIuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM0Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
truecharts-admin
referenced
this pull request
in truecharts/public
May 6, 2024
…0.8.13@43a3ee8 by renovate (#21685) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.12` -> `v0.8.13` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.13`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.13) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.12...v0.8.13) #### What's Changed - Enhancement: configurable CPU temp scale by [@​daviddavid](https://togithub.com/daviddavid) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3332](https://togithub.com/gethomepage/homepage/pull/3332) - Enhancement: additional tautulli jellyfin emby configuration options by [@​ameerabdallah](https://togithub.com/ameerabdallah) in [https://github.com/gethomepage/homepage/pull/3350](https://togithub.com/gethomepage/homepage/pull/3350) - Enhancement: add bitrate precision config option for speedtest-tracker by [@​ameerabdallah](https://togithub.com/ameerabdallah) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3354](https://togithub.com/gethomepage/homepage/pull/3354) - Fix: format Romm statistics by [@​EdwardSalter](https://togithub.com/EdwardSalter) in [https://github.com/gethomepage/homepage/pull/3358](https://togithub.com/gethomepage/homepage/pull/3358) - Fix some unsanitized error URLs by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3385](https://togithub.com/gethomepage/homepage/pull/3385) - Chore(deps): Bump recharts from 2.12.3 to 2.12.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3397](https://togithub.com/gethomepage/homepage/pull/3397) - Chore(deps-dev): Bump typescript from 4.9.5 to 5.4.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3396](https://togithub.com/gethomepage/homepage/pull/3396) - Chore(deps): Bump systeminformation from 5.22.0 to 5.22.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3398](https://togithub.com/gethomepage/homepage/pull/3398) - Chore(deps): Bump react from 18.2.0 to 18.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3400](https://togithub.com/gethomepage/homepage/pull/3400) - Chore(deps-dev): Bump eslint-config-next from 12.3.4 to 14.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3399](https://togithub.com/gethomepage/homepage/pull/3399) #### New Contributors - [@​daviddavid](https://togithub.com/daviddavid) made their first contribution in [https://github.com/gethomepage/homepage/pull/3332](https://togithub.com/gethomepage/homepage/pull/3332) - [@​ameerabdallah](https://togithub.com/ameerabdallah) made their first contribution in [https://github.com/gethomepage/homepage/pull/3350](https://togithub.com/gethomepage/homepage/pull/3350) - [@​EdwardSalter](https://togithub.com/EdwardSalter) made their first contribution in [https://github.com/gethomepage/homepage/pull/3358](https://togithub.com/gethomepage/homepage/pull/3358) **Full Changelog**: gethomepage/homepage@v0.8.12...v0.8.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM0My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
github-merge-queue bot
referenced
this pull request
in chezmoi-sh/atlas
May 19, 2024
…114) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.12` -> `v0.8.13` | [](https://securityscorecards.dev/viewer/?uri=github.com/gethomepage/homepage) | --- ### Release Notes <details> <summary>gethomepage/homepage (gethomepage/homepage)</summary> ### [`v0.8.13`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.13) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.12...v0.8.13) ##### What's Changed - Enhancement: configurable CPU temp scale by [@​daviddavid](https://togithub.com/daviddavid) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3332](https://togithub.com/gethomepage/homepage/pull/3332) - Enhancement: additional tautulli jellyfin emby configuration options by [@​ameerabdallah](https://togithub.com/ameerabdallah) in [https://github.com/gethomepage/homepage/pull/3350](https://togithub.com/gethomepage/homepage/pull/3350) - Enhancement: add bitrate precision config option for speedtest-tracker by [@​ameerabdallah](https://togithub.com/ameerabdallah) and [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3354](https://togithub.com/gethomepage/homepage/pull/3354) - Fix: format Romm statistics by [@​EdwardSalter](https://togithub.com/EdwardSalter) in [https://github.com/gethomepage/homepage/pull/3358](https://togithub.com/gethomepage/homepage/pull/3358) - Fix some unsanitized error URLs by [@​shamoon](https://togithub.com/shamoon) in [https://github.com/gethomepage/homepage/pull/3385](https://togithub.com/gethomepage/homepage/pull/3385) - Chore(deps): Bump recharts from 2.12.3 to 2.12.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3397](https://togithub.com/gethomepage/homepage/pull/3397) - Chore(deps-dev): Bump typescript from 4.9.5 to 5.4.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3396](https://togithub.com/gethomepage/homepage/pull/3396) - Chore(deps): Bump systeminformation from 5.22.0 to 5.22.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3398](https://togithub.com/gethomepage/homepage/pull/3398) - Chore(deps): Bump react from 18.2.0 to 18.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3400](https://togithub.com/gethomepage/homepage/pull/3400) - Chore(deps-dev): Bump eslint-config-next from 12.3.4 to 14.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gethomepage/homepage/pull/3399](https://togithub.com/gethomepage/homepage/pull/3399) ##### New Contributors - [@​daviddavid](https://togithub.com/daviddavid) made their first contribution in [https://github.com/gethomepage/homepage/pull/3332](https://togithub.com/gethomepage/homepage/pull/3332) - [@​ameerabdallah](https://togithub.com/ameerabdallah) made their first contribution in [https://github.com/gethomepage/homepage/pull/3350](https://togithub.com/gethomepage/homepage/pull/3350) - [@​EdwardSalter](https://togithub.com/EdwardSalter) made their first contribution in [https://github.com/gethomepage/homepage/pull/3358](https://togithub.com/gethomepage/homepage/pull/3358) **Full Changelog**: gethomepage/homepage@v0.8.12...v0.8.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/WIP-monorepo). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add new widget configuration option for speedtest-tracker widget to configure the number of decimal places it will print the bitrate at. (
bitrateNumOfDecimalPlaces)It will now default to 2 decimal places but can be configured for any non-negative integer. If an invalid value is passed in, it will fallback to the default value.
with
bitrateNumOfDecimalPlaces: 3:with
bitrateNumOfDecimalPlaces: 0:with
bitrateNumOfDecimalPlaces: -3(falls back to default):Closes #1308 (issue)
Type of change
Checklist: