Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: omada widget missing switches field, enforce default and max fields #3047

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Mar 1, 2024

Proposed change

Closes #3045
Closes #3046

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon merged commit 473b2d2 into main Mar 1, 2024
2 checks passed
@shamoon shamoon deleted the fix-3045 branch March 1, 2024 19:30
@shamoon shamoon restored the fix-3045 branch March 3, 2024 16:44
@shamoon shamoon deleted the fix-3045 branch March 3, 2024 16:44
denispapec pushed a commit to denispapec/homepage that referenced this pull request Mar 17, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Omada widget not showing connected switches
1 participant