Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added agenda view for calendar, calendar improvements #2216

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Feature: Added agenda view for calendar, calendar improvements #2216

merged 9 commits into from
Oct 20, 2023

Conversation

denispapec
Copy link
Contributor

@denispapec denispapec commented Oct 20, 2023 •
edited by shamoon
Loading

Proposed change

This PR adds agenda view for calendar, contains additional improvements to show when event has completed status (for example media has available file), and add additional configuration to limit number of events in the event list.

Closes #2106
Closes #2097

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If adding a service widget or a change that requires it, I have added corresponding documentation changes.
  • If adding a new widget I have reviewed the guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks with pnpm lint (see development guidelines).
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Collaborator

shamoon commented Oct 20, 2023

Thanks as always, I did run into a bunch of issues. The commits should explain most of them.

I also changed things to only show the date once (as suggested on discord), I think thats a good idea.

The hardest thing was getting long titles to behave. Truncating them to the arbitrary 42 characters just doesnt work if e.g. the calendar is very wide or if 5 columns is enabled (breaks the column layout), so I ended up with something a bit more convoluted (absolutely positioned div), certainly welcome another solution there.

Anyway, let us know your thoughts or any concerns with this.

@shamoon shamoon added the enhancement New feature or request label Oct 20, 2023
@denispapec
Copy link
Contributor Author

Thanks, yeah, long titles annoyed me too 🙈 , thanks for having a look at that and other bits.
I've noticed one issue where it duplicates the showDate still and that is because event date is actual airDate, and I want to preserve that till rendering and not to modify early on.

LGTM

@shamoon shamoon enabled auto-merge (squash) October 20, 2023 23:30
shamoon
shamoon approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great work

@shamoon shamoon merged commit 6898faa into gethomepage:main Oct 20, 2023
5 checks passed
spiceratops referenced this pull request in spiceratops/k8s-gitops Nov 10, 2023
@spiceratops
feat(container): update image ghcr.io/gethomepage/homepage to v0.8.0 (#…
e56779f 
…250)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| minor | `v0.7.4` -> `v0.8.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.0`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.0)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.7.4...v0.8.0)

#### ⚠️ Breaking Changes

- This release changes the `ping` feature to actually perform a system
ping which may yield different results than the previous implementation.
The old `ping` has been renamed `siteMonitor` to more accurately reflect
what it does. See [the
docs](https://gethomepage.dev/v0.8.0/configs/services/#site-monitor).
- Homepage is also now more strict about using the correct protocol
(e.g. https:// vs http://) for proxied URLs such as widget URLs

#### What's Changed

- Fix: Tab spacing on mobile by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2209](https://togithub.com/gethomepage/homepage/pull/2209)
- Change: Enable `autoSelectFamily` for http(s) requests by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2214](https://togithub.com/gethomepage/homepage/pull/2214)
- Feature: true ping, rename old ping to siteMonitor by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2215](https://togithub.com/gethomepage/homepage/pull/2215)
- Feature: Added agenda view for calendar, calendar improvements by
[@&#8203;denispapec](https://togithub.com/denispapec) in
[https://github.com/gethomepage/homepage/pull/2216](https://togithub.com/gethomepage/homepage/pull/2216)
- Feature: add date formatting option in custom api by
[@&#8203;equuskk](https://togithub.com/equuskk) in
[https://github.com/gethomepage/homepage/pull/2228](https://togithub.com/gethomepage/homepage/pull/2228)
- Fix: override some colors for white theme by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2242](https://togithub.com/gethomepage/homepage/pull/2242)
- Fix authentik users endpoint URL by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2244](https://togithub.com/gethomepage/homepage/pull/2244)
- Fix: octoprint error when progress empty by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2247](https://togithub.com/gethomepage/homepage/pull/2247)
- Fix: Synology DownloadStation units by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2249](https://togithub.com/gethomepage/homepage/pull/2249)
- Fix: Respect hideErrors for Calendar widget by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2259](https://togithub.com/gethomepage/homepage/pull/2259)
- Feature: iFrame widget by
[@&#8203;Reiss-Cashmore](https://togithub.com/Reiss-Cashmore) in
[https://github.com/gethomepage/homepage/pull/2261](https://togithub.com/gethomepage/homepage/pull/2261)
- Fix: container memory_stats in podman by
[@&#8203;idelsink](https://togithub.com/idelsink) in
[https://github.com/gethomepage/homepage/pull/2272](https://togithub.com/gethomepage/homepage/pull/2272)
- Fix: support Unifi widget with Unifi OS v3.2.5+ by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2281](https://togithub.com/gethomepage/homepage/pull/2281)
- Fix: handle immich v1.85.0 breaking change by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/2284](https://togithub.com/gethomepage/homepage/pull/2284)

#### New Contributors

- [@&#8203;equuskk](https://togithub.com/equuskk) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/2228](https://togithub.com/gethomepage/homepage/pull/2228)
- [@&#8203;Reiss-Cashmore](https://togithub.com/Reiss-Cashmore) made
their first contribution in
[https://github.com/gethomepage/homepage/pull/2261](https://togithub.com/gethomepage/homepage/pull/2261)
- [@&#8203;idelsink](https://togithub.com/idelsink) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/2272](https://togithub.com/gethomepage/homepage/pull/2272)

**Full Changelog**:
gethomepage/homepage@v0.7.4...v0.8.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuNTEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
@fizzyhd
Copy link

fizzyhd commented Jan 22, 2024

Is there a way to make the different event dot colors customizable through the yaml files?

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
@denispapec denispapec deleted the agenda branch May 5, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denispapec @shamoon @fizzyhd