-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve proxmox #1676
Improve proxmox #1676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but service widgets should only use the block style, please remove that change.
I cant test as I dont have proxmox, @JazzFisch does but not sure if he's available to test
Alright, I'll remove that then. Is there another way to customise the appearance of these kind of blocks? |
No, at the moment consistency > fanciness :) |
Great, again someone else will have to test. Also, please squash the 8 commits |
Saw that QA was failing so I fixed that now (hopefully). |
a16f2da
to
43b5263
Compare
It's not a big deal, yes we can squash here or you can force-push. Different projects do it differently, theres no real clear consensus here |
I can test with my proxmox installation if that is allowed |
I've tested it on my own cluster as well. Not sure it @JazzFisch is available for testing. But I don't see how we can test it otherwise |
Well I hope you did yes 😉 but some external validation would be good |
Completely understand haha |
I've tested and works flawesly, thanks!!! |
Do you think is possible to have also cpu/men for a specific lxc/VM? we can use proxmox widget in any service to show cpu/men. Thanks |
#1749 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
The following changes have been done to the proxmox widget:
Without the node filter, the averages across all nodes will be calculated. I've considered the original behaviour a bug and because of that, not a breaking change. I can however make the new display optional by introducing another config value, but I didn't want to over-complicate the configuration without a good reason.
References #1290
Type of change
Checklist:
pnpm lint
.