Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add ArgoCD widget #4305

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

fcornelius
Copy link
Contributor

Proposed change

This adds a widget for ArgoCD. It can list the count of apps present in an ArgoCD instance by app status, e.g. synced or healthy.

image

Closes #2644

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The length of the docs here backs up my theory that k8s is too complicated. If you’d think there’s a way to make it more concise (mostly linking to other places ) that’d be great, I didn’t see anything obvious.

As for the widget, if you wouldn’t mind copy pasting some sample api output for me to test.

Finally, one thing is all widgets should display no more than 4 blocks. I’ll have a real look once you have a chance to supply the above.

thanks

@fcornelius
Copy link
Contributor Author

fcornelius commented Nov 19, 2024

I feel you, the doc however is not related to kubernetes itself. It's due to the way roles are configured in ArgoCD, which is a little unintuitive and I wanted to include a security best practice rather than just the quickest solution to get it running.

Limited the maximum fields shown to 4 now.

Sample API response to test with: <removed>
This one should yield the fields:
apps: 4, synced: 2, outOfSync: 2, healthy: 1, missing: 1, degraded: 1, progressing: 1

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to work well just some small things.

Screenshot 2024-11-19 at 12 50 03 PM

src/widgets/argocd/component.jsx Outdated Show resolved Hide resolved
src/widgets/argocd/component.jsx Outdated Show resolved Hide resolved
public/locales/en/common.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks

@shamoon shamoon merged commit 4a3a4c8 into gethomepage:dev Nov 19, 2024
7 checks passed
@fcornelius
Copy link
Contributor Author

Awesome thanks

Thank you for this cool project!

@fcornelius fcornelius deleted the feature/2644-argocd-widget branch November 19, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants