Skip to content

Commit

Permalink
Enhancement: npm widget support ≥ v2.12 (#4140)
Browse files Browse the repository at this point in the history
  • Loading branch information
shamoon authored Oct 16, 2024
1 parent cf91093 commit aac573a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/widgets/npm/component.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ export default function Component({ service }) {
);
}

const enabled = infoData.filter((c) => c.enabled === 1).length;
const disabled = infoData.filter((c) => c.enabled === 0).length;
const enabled = infoData.filter((c) => !!c.enabled).length;
const disabled = infoData.filter((c) => !c.enabled).length;
const total = infoData.length;

return (
Expand Down
7 changes: 3 additions & 4 deletions src/widgets/npm/proxy.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ async function login(loginUrl, username, password, service) {
cache.put(`${tokenCacheKey}.${service}`, data.token, expiration - 5 * 60 * 1000); // expiration -5 minutes
}
} catch (e) {
logger.error(`Error ${status} logging into npm`, authResponse[2]);
logger.error(`Error ${status} logging into npm`, JSON.stringify(authResponse[2]));
}
return [status, data.token ?? data];
}
Expand All @@ -50,7 +50,6 @@ export default async function npmProxyHandler(req, res) {
const loginUrl = `${widget.url}/api/tokens`;

let status;
let contentType;
let data;

let token = cache.get(`${tokenCacheKey}.${service}`);
Expand All @@ -62,7 +61,7 @@ export default async function npmProxyHandler(req, res) {
}
}

[status, contentType, data] = await httpProxy(url, {
[status, , data] = await httpProxy(url, {
method: "GET",
headers: {
"Content-Type": "application/json",
Expand All @@ -81,7 +80,7 @@ export default async function npmProxyHandler(req, res) {
}

// eslint-disable-next-line no-unused-vars
[status, contentType, data] = await httpProxy(url, {
[status, , data] = await httpProxy(url, {
method: "GET",
headers: {
"Content-Type": "application/json",
Expand Down

0 comments on commit aac573a

Please sign in to comment.