Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Null Coalesce Operator #2466

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Use Null Coalesce Operator #2466

merged 1 commit into from
Apr 20, 2019

Conversation

carusogabriel
Copy link
Contributor

Just a small refactoring 💅

@rhukster rhukster merged commit be8eb63 into getgrav:develop Apr 20, 2019
@mahagr
Copy link
Member

mahagr commented Apr 23, 2019

Nope, it was not refactoring, it actually broke the code. You cannot replace array_key_exists() call with ??, the meaning of the code changes.

mahagr added a commit that referenced this pull request Apr 23, 2019
@mahagr
Revert "Use Null Coalesce Operator (#2466)"
471e3d8 
This reverts commit be8eb63
@mahagr
Copy link
Member

mahagr commented Apr 23, 2019

Reverted the code.

@carusogabriel
Copy link
Contributor Author

@managr Maybe we should add a test than?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carusogabriel @mahagr @rhukster