Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally remove unpublished pages from the translated languages, move into untranslated list #1482

Merged
merged 3 commits into from
May 19, 2017

Conversation

flaviocopes
Copy link
Contributor

@flaviocopes
Copy link
Contributor Author

Probably need to add a flag as it changes the current behavior

@mahagr
Copy link
Member

mahagr commented May 18, 2017

Hmm.. I think it may be a good idea to add a parameter to get all pages even if they aren't published.. Also what if user has permission to access only some translations?

@flaviocopes
Copy link
Contributor Author

Yes it needs a parameter also because Admin relies on this to manage translations. Permission-related, this only returns the routes to other pages, so once you change the language, you can use the usual permissions checks

Copy link
Member

@rhukster rhukster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mahagr
Copy link
Member

mahagr commented May 19, 2017

Yup, same here.

@flaviocopes flaviocopes merged commit ce32a08 into develop May 19, 2017
@flaviocopes flaviocopes deleted the feature/unpublished-lang-untranslated branch May 19, 2017 08:01
@flaviocopes flaviocopes changed the title Remove unpublished pages from the translated languages, move into untranslated list Optionally remove unpublished pages from the translated languages, move into untranslated list May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants