Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageLoadingTrait: Incorrect config lookup for loading #3192

Closed
pamtbaau opened this issue Feb 1, 2021 · 0 comments
Closed

ImageLoadingTrait: Incorrect config lookup for loading #3192

pamtbaau opened this issue Feb 1, 2021 · 0 comments
Assignees
@mahagr
Labels
bug fixed

Comments

@pamtbaau
Copy link
Contributor

pamtbaau commented Feb 1, 2021

ImageLoadingTrait::loading() will never find config system.images.defaults.loading.

ImageLoadingTrait.php:L29 is currently:

$value = Grav::instance()['config']->get('images.defaults.loading', 'auto');

should be:

$value = Grav::instance()['config']->get('system.images.defaults.loading', 'auto');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahagr mahagr

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahagr @pamtbaau