onAdminSave($event) passes page as $event['object'] or $event['page'] depending on regular/flex page

[pamtbaau]

When subscribing to onAdminSave event, a different Event object is passed when saving a 'regular' page versus a 'flex' page.

regular: $event['object']
flex: $event['page']

This will break plugins that want to intercept the saving of a page.

[mahagr]

For Flex Pages it should be the same, yes (which looks like to be a bug), but the event passes object variable in the older version, too, so you need to check if you're saving a page or not.

[pamtbaau]

Yes, the type of object passed into eventhandler is being checked.

Current workaround:

$page = $event['object'] ?? $event['page'];

if (!$page instanceof Page && !$page instanceof PageObject) {
    return;
}

[rhukster]

The bug is that they should both send the page as ['page'] on the event, however now it’s sent as PageInterface and that can be used the same for regular pages or flex. Should not be ['object']

[mahagr]

@rhukster Looks like there are a lot of inconsistencies in how the admin deals with the page events. All the other events use page instead of object.

[mahagr]

I updated the other events to use object as well (page variable is still there for backwards compatibility).

[pamtbaau]

Thanks @mahagr 👍