Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticImageMedium returns wrong HTML tag? #1001

Closed
chaoslion opened this issue Aug 23, 2016 · 3 comments
Closed

StaticImageMedium returns wrong HTML tag? #1001

chaoslion opened this issue Aug 23, 2016 · 3 comments
Labels

Comments

@chaoslion
Copy link

chaoslion commented Aug 23, 2016

Hey Guys,

i have a .gif image and Grav renders it in an <image> Tag.
Problem lies in the StaticImageMedium class in line 26:
return [ 'name' => 'image', 'attributes' => $attributes ];
Shouldn't name actually be 'img' ?

-chslion

@flaviocopes
Copy link
Contributor

flaviocopes commented Aug 24, 2016

That's weird. Can you paste the relevant parts of the markdown/twig code you used to get that image tag?

@chaoslion
Copy link
Author

I just tried it with a fresh install of the latest Grav Release (1.1.3) and Chrome (Version 51.0.2704.79 Ubuntu 15.10) shows the <image> Tag in the html source.

I used the shipped welcome page with the following markdown

![Gif Image](foo.gif)

source

The Element Inspector changes the image tag to a valid img tag.

inspector

@rhukster
Copy link
Member

I can confirm this is a bug.. Never noticed because it is rendered fine in Chrome. BTW, in the future, you can submit a PR as you already had the fix :) Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants