Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add important notice about rerouting paths containing regex characters #963

Merged

Conversation

hughbris
Copy link
Contributor

Found this important info snippet in an issue comment explaining why some legacy redirects didn't work. IMO it's a detail that needs to be documented in a more obvious place.

@mahagr
Copy link
Member

mahagr commented Jan 11, 2022

It may be also useful to add some examples on how to match the exact route and how to properly match routes to folders.

@hughbris
Copy link
Contributor Author

I agree and thinking about this overnight, this was already too much detail for a warning box really. It probably needs a proper subsection to cover properly. I will ponder that.

@rhukster rhukster merged commit 387c61a into getgrav:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants