Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-511 Image intersection issues #894

Merged
merged 4 commits into from
Dec 17, 2024
Merged

ENG-511 Image intersection issues #894

merged 4 commits into from
Dec 17, 2024

Conversation

matvlaovi-flip
Copy link
Collaborator

Summary

This solution is based on two ideas:

  1. As clients (Angular in our case) render the DOM, these images might at some point be intersecting with the viewport, while it's not visible to the user. Instead of checking all of the intersection entries, we should only check the last one, as it's the "final" state that the user sees.
  2. Sometimes browsers won't be able to bundle these intersection entries together, e.g. when you manually reload. This is why I also introduced a debounce so that we again only handle the last state.

Additionally sorted the entries as recommended by MDN

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
getflipdev ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:56am
staginggetflipdev ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:56am

@matvlaovi-flip matvlaovi-flip changed the title Eng 511 image intersection issues ENG-511 Image intersection issues Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-894.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-894.westeurope.3.azurestaticapps.net

@matvlaovi-flip matvlaovi-flip merged commit 96108e1 into main Dec 17, 2024
9 checks passed
@matvlaovi-flip matvlaovi-flip deleted the eng-511-image-intersection-issues branch December 17, 2024 09:14
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sqrrl Sqrrl Sqrrl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matvlaovi-flip @Sqrrl